Add newly added rules to the coding standards index#54
Closed
kacper-mikolajczak wants to merge 750 commits into
Closed
Add newly added rules to the coding standards index#54kacper-mikolajczak wants to merge 750 commits into
kacper-mikolajczak wants to merge 750 commits into
Conversation
[NoQA] Fix false broken connection banner on Company Cards page for non-direct card feeds
…nse-chat-report-actions
…bump-lottie Upgrade `lottie-react-native` to the latest version
…live-markdown-0.1.327 chore: upgrade react-native-live-markdown to 0.1.327
…emove-explanation-modal [No QA] Remove explanation modal
fix: New workflow is not added via Import Spreadsheet in a control WS
- Drop "exactly once" overstatement: writes are sent serially and deduplicated server-side on the rare resend, not via a client-side lock. - Distinguish push()'s offline-at-entry path (returns without arming the READ gate) from going offline during the awaited persist. - Reframe restart head-dedupe as a defensive backstop, consistent with the atomic multiSet promotion. - Restate remaining time-based phrasing as current-state facts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nedPaidPoliciesCountsSelector
…h-selection-writeside Search selection: move write-side off <Search> onto provider/controller
…2b-invoice-report
Fix: “Reimbursable” column width is wider than necessary on report page
…rkspaces-list-page-composition-1 extract DeleteWorkspaceFlow component from WorkspacesListPage
[Submit] Add editor role to the filter for submit workspace
…ss-copy [NoQA] Update specialized role access copy
…r-multi-select feat: Make the Workspace and Domain member filter list multi-select, and update All members to Members
…cemaps [No QA] Patch time-analytics-webpack-plugin to fix sourcemaps
…nnect-patterns Stop repeated ReconnectApp calls when the device clock is behind the server
fix: Creating report from self dm opens hmm not here page briefly
Update the domain admins table to the new style
…ingCustomizeCategories Route Getting Started accounting row to categories for non-direct integrations
…/fix-global-create-scan [Performance] Fix global create scan misidentifying Search context via fallback chain
…xpenseChatEnabled-A1 [Payment due @Ollyws] Remove `isPolicyExpenseChatEnabled` from `PolicyUtils.ts` helpers
…policy-expense-chat-report-actions Defer policy expense chat report actions computation off the render path
…in-rules [Payment due @marufsharifi] Add currency selection to card rules
Revert Expensify#92007 Concierge AI Feature Promo Modal
The coding standards index listed only the rules that existed when it was written. Several rules added since then were missing from both the categories table and the quick reference, including an entire UI category that had no entry at all. Add a UI category and list the new UI, consistency, and clean-react rules so the index reflects every rule file in the directory.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Recreating against upstream Expensify/App. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The coding standards index (
.claude/skills/coding-standards/SKILL.md) listed only the rules that existed when it was written. Several rules added since then were missing from both the categories table and the quick reference, including an entire UI category that had no entry at all. The index no longer reflected the rule files actually present in the directory.Fix
UIcategory to the categories table.CONSISTENCY-7..11,CLEAN-REACT-6..9, andUI-1..3.Every rule file in
rules/is now represented in the index, and every link resolves.Notes
The four newest clean-react rules use the id prefix
CLEAN-REACT-while the earlier ones useCLEAN-REACT-PATTERNS-. They are listed here by their actual ids so the links are accurate. Normalizing that prefix is out of scope for this change.Tests
.claude/skills/coding-standards/rules/is referenced inSKILL.md.rules/*.mdlink inSKILL.mdpoints to an existing file.