fix: add fallback label in getBudgetedHealErrorLabel

leshniak · claude · leshniak · commit 00e8667b1c51 · 2026-05-29T16:06:08.000+02:00
Avoid silently mislabeling future error categories as connection lost.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/lib/storage/providers/IDBKeyValProvider/createStore.ts b/lib/storage/providers/IDBKeyValProvider/createStore.ts
@@ -33,8 +33,10 @@ function isBudgetedHealError(error: unknown): boolean {
     return isBackingStoreError(error) || isConnectionLostError(error);
 }
 
-function getBudgetedHealErrorLabel(error: unknown): 'backing store' | 'connection lost' {
-    return isBackingStoreError(error) ? 'backing store' : 'connection lost';
+function getBudgetedHealErrorLabel(error: unknown): string {
+    if (isBackingStoreError(error)) return 'backing store';
+    if (isConnectionLostError(error)) return 'connection lost';
+    return 'unknown';
 }
 
 /** Union of all error types indicating a stale/dead IDB connection. Used by the visibilitychange probe. */

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,10 @@ function isBudgetedHealError(error: unknown): boolean {`
`33`	`33`	`return isBackingStoreError(error) \|\| isConnectionLostError(error);`
`34`	`34`	`}`
`35`	`35`
`36`		`-function getBudgetedHealErrorLabel(error: unknown): 'backing store' \| 'connection lost' {`
`37`		`- return isBackingStoreError(error) ? 'backing store' : 'connection lost';`
	`36`	`+function getBudgetedHealErrorLabel(error: unknown): string {`
	`37`	`+ if (isBackingStoreError(error)) return 'backing store';`
	`38`	`+ if (isConnectionLostError(error)) return 'connection lost';`
	`39`	`+ return 'unknown';`
`38`	`40`	`}`
`39`	`41`
`40`	`42`	`/** Union of all error types indicating a stale/dead IDB connection. Used by the visibilitychange probe. */`