Skip to content

Commit 1d77980

Browse files
committed
Add try/catch to fireCallbacks()
1 parent 4049c58 commit 1d77980

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

lib/OnyxConnectionManager.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,18 @@ class OnyxConnectionManager {
136136
}
137137

138138
for (const callback of connection.callbacks.values()) {
139-
if (OnyxKeys.isCollectionKey(connection.onyxKey)) {
140-
(callback as CollectionConnectCallback<OnyxKey>)(connection.cachedCallbackValue as Record<string, unknown>, connection.cachedCallbackKey as OnyxKey, connection.sourceValue);
141-
} else {
142-
(callback as DefaultConnectCallback<OnyxKey>)(connection.cachedCallbackValue, connection.cachedCallbackKey as OnyxKey);
139+
try {
140+
if (OnyxKeys.isCollectionKey(connection.onyxKey)) {
141+
(callback as CollectionConnectCallback<OnyxKey>)(
142+
connection.cachedCallbackValue as Record<string, unknown>,
143+
connection.cachedCallbackKey as OnyxKey,
144+
connection.sourceValue,
145+
);
146+
} else {
147+
(callback as DefaultConnectCallback<OnyxKey>)(connection.cachedCallbackValue, connection.cachedCallbackKey as OnyxKey);
148+
}
149+
} catch (error) {
150+
Logger.logAlert(`[ConnectionManager] Subscriber callback threw an error for key '${connection.onyxKey}': ${error}`);
143151
}
144152
}
145153
}

0 commit comments

Comments
 (0)