add solution to removeItem

Author: sosek108

lib/storage/providers/IDBKeyValProvider/index.ts

@@ -153,14 +153,22 @@ const provider: StorageProvider<UseStore | undefined> = {
             throw new Error('Store not initialized!');
         }
 
-        return IDB.del(key, provider.store);
+        return provider.store('readwrite', (store) => {
+            store.delete(key);
+            return promisifyWriteTransaction(store.transaction);
+        });
     },
     removeItems(keysParam) {
         if (!provider.store) {
             throw new Error('Store not initialized!');
         }
 
-        return IDB.delMany(keysParam, provider.store);
+        return provider.store('readwrite', (store) => {
+            for (const key of keysParam) {
+                store.delete(key);
+            }
+            return promisifyWriteTransaction(store.transaction);
+        });
     },
     getDatabaseSize() {
         if (!provider.store) {

tests/unit/storage/providers/IDBKeyvalProviderTest.ts

@@ -176,11 +176,9 @@ describe('IDBKeyValProvider', () => {
 
     describe('write-error normalization (aborted transactions)', () => {
         // A write transaction aborted by something other than its own request (connection close,
-        // versionchange, a sibling transaction) leaves `transaction.error === null`. idb-keyval
-        // rejects with that null, which is unclassifiable: it slips past createStore's heal guards
-        // (they require an Error/DOMException) and renders as the production log line
-        // "[Onyx] Failed to save to storage. Error: null". Every write path must instead reject
-        // with a real Error so the failure can be classified and retried sanely.
+        // versionchange, a sibling transaction) leaves `transaction.error === null`, which idb-keyval
+        // rejects with as-is. Every write path must instead reject with a real Error so the failure
+        // can be classified and retried.
         function abortTransactionOnPut() {
             const originalPut = IDBObjectStore.prototype.put;
             jest.spyOn(IDBObjectStore.prototype, 'put').mockImplementation(function put(this: IDBObjectStore, ...args: Parameters<IDBObjectStore['put']>) {
@@ -190,6 +188,15 @@ describe('IDBKeyValProvider', () => {
             });
         }
 
+        function abortTransactionOnDelete() {
+            const originalDelete = IDBObjectStore.prototype.delete;
+            jest.spyOn(IDBObjectStore.prototype, 'delete').mockImplementation(function del(this: IDBObjectStore, ...args: Parameters<IDBObjectStore['delete']>) {
+                const request = originalDelete.apply(this, args);
+                this.transaction.abort();
+                return request;
+            });
+        }
+
         function expectAbortError(error: unknown) {
             expect(error).not.toBeNull();
             expect(error).toBeInstanceOf(DOMException);
@@ -218,6 +225,24 @@ describe('IDBKeyValProvider', () => {
             const error = await IDBKeyValProvider.multiMerge([[ONYXKEYS.TEST_KEY, 'value']]).catch((e: unknown) => e);
             expectAbortError(error);
         });
+
+        it('should reject setItem(null) with a tagged AbortError, never null', async () => {
+            abortTransactionOnDelete();
+            const error = await IDBKeyValProvider.setItem(ONYXKEYS.TEST_KEY, null).catch((e: unknown) => e);
+            expectAbortError(error);
+        });
+
+        it('should reject removeItem with a tagged AbortError, never null', async () => {
+            abortTransactionOnDelete();
+            const error = await IDBKeyValProvider.removeItem(ONYXKEYS.TEST_KEY).catch((e: unknown) => e);
+            expectAbortError(error);
+        });
+
+        it('should reject removeItems with a tagged AbortError, never null', async () => {
+            abortTransactionOnDelete();
+            const error = await IDBKeyValProvider.removeItems([ONYXKEYS.TEST_KEY]).catch((e: unknown) => e);
+            expectAbortError(error);
+        });
     });
 
     describe('mergeItem', () => {