fix: address review - remove document guard and ReconnectApp mention

- Remove the `typeof document !== 'undefined'` guard; IDBKeyValProvider
  runs on web only, where document is always defined.
- Drop the App-specific "ReconnectApp" reference from the probe comment.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: elirangoshen

lib/storage/providers/IDBKeyValProvider/createStore.ts

@@ -133,51 +133,49 @@ function createStore(dbName: string, storeName: string): UseStore {
     }
 
     // Proactive IDB health check when tab returns to foreground.
-    // Safari kills IDB connections for backgrounded tabs. By probing before
-    // the ReconnectApp write storm hits, we drop the stale dbp early so the
-    // first real operation opens a fresh connection instead of failing.
-    if (typeof document !== 'undefined') {
-        document.addEventListener('visibilitychange', () => {
-            if (document.visibilityState !== 'visible' || !dbp) {
-                return;
-            }
+    // Safari kills IDB connections for backgrounded tabs. By probing as soon as
+    // the tab becomes visible, we drop the stale dbp early so the first real
+    // operation opens a fresh connection instead of failing.
+    document.addEventListener('visibilitychange', () => {
+        if (document.visibilityState !== 'visible' || !dbp) {
+            return;
+        }
 
-            Logger.logInfo('IDB visibilitychange probe: tab became visible, checking connection health', {dbName, storeName});
+        Logger.logInfo('IDB visibilitychange probe: tab became visible, checking connection health', {dbName, storeName});
 
-            const probePromise = dbp;
+        const probePromise = dbp;
 
-            const dropCacheIfStale = (error: unknown) => {
-                if (dbp !== probePromise || !isStaleConnectionError(error)) {
-                    return;
-                }
-                Logger.logAlert('IDB visibilitychange probe: stale connection detected, dropping cached connection', {
-                    dbName,
-                    storeName,
-                    errorMessage: error instanceof Error ? error.message : String(error),
-                });
-                dbp = undefined;
-            };
-
-            probePromise.then((db) => {
-                if (dbp !== probePromise) {
-                    return;
-                }
-                try {
-                    const tx = db.transaction(storeName, 'readonly');
-                    const probeStore = tx.objectStore(storeName);
-                    const req = probeStore.count();
-                    req.onsuccess = () => {
-                        Logger.logInfo('IDB visibilitychange probe: connection is healthy', {dbName, storeName});
-                    };
-                    req.onerror = () => {
-                        dropCacheIfStale(req.error);
-                    };
-                } catch (error) {
-                    dropCacheIfStale(error);
-                }
+        const dropCacheIfStale = (error: unknown) => {
+            if (dbp !== probePromise || !isStaleConnectionError(error)) {
+                return;
+            }
+            Logger.logAlert('IDB visibilitychange probe: stale connection detected, dropping cached connection', {
+                dbName,
+                storeName,
+                errorMessage: error instanceof Error ? error.message : String(error),
             });
+            dbp = undefined;
+        };
+
+        probePromise.then((db) => {
+            if (dbp !== probePromise) {
+                return;
+            }
+            try {
+                const tx = db.transaction(storeName, 'readonly');
+                const probeStore = tx.objectStore(storeName);
+                const req = probeStore.count();
+                req.onsuccess = () => {
+                    Logger.logInfo('IDB visibilitychange probe: connection is healthy', {dbName, storeName});
+                };
+                req.onerror = () => {
+                    dropCacheIfStale(req.error);
+                };
+            } catch (error) {
+                dropCacheIfStale(error);
+            }
         });
-    }
+    });
 
     // Handles three recoverable error classes:
     // 1. InvalidStateError — connection closed between getDB() resolving and db.transaction().