move recordEviction after remove

Author: sosek108

lib/OnyxUtils.ts

@@ -887,14 +887,19 @@ function retryOperation<TMethod extends RetriableOnyxOperation>(
         return reportStorageQuota(error);
     }
 
-    // Remove the least recently accessed key and retry. Tell the breaker we evicted so that, if the
-    // retry comes back as another capacity failure, it counts as a no-progress cycle.
+    // Remove the least recently accessed key and retry.
     Logger.logInfo(`Out of storage. Evicting least recently accessed key (${keyForRemoval}) and retrying. Error: ${error}`);
     reportStorageQuota(error);
-    StorageCircuitBreaker.recordEviction();
 
     // @ts-expect-error No overload matches this call.
-    return remove(keyForRemoval).then(() => onyxMethod(defaultParams, nextRetryAttempt));
+    return remove(keyForRemoval).then(() => {
+        // Mark the eviction only once the deletion has actually completed, immediately before the
+        // retry it pairs with. Recording earlier lets a concurrent write's capacity failure consume
+        // the marker as a no-progress cycle while this deletion is still pending and may yet free
+        // space — so the verdict belongs to the retry that follows the deletion, not the eviction call.
+        StorageCircuitBreaker.recordEviction();
+        return onyxMethod(defaultParams, nextRetryAttempt);
+    });
 }
 
 /**