chore: remove ensure-simulator lifecycle command (#552)

Author: thymikee

fallow-baselines/health.json

@@ -687,14 +687,6 @@
         "count": 1
       }
     },
-    "src/platforms/ios/ensure-simulator.ts": {
-      "complexity_moderate": {
-        "count": 1
-      },
-      "crap_moderate": {
-        "count": 1
-      }
-    },
     "src/platforms/ios/interactions.ts": {
       "complexity_critical": {
         "count": 1
@@ -999,4 +991,4 @@
     "src/daemon/screenshot-overlay.ts:untested risk",
     "src/utils/screenshot-diff-non-text.ts:complexity"
   ]
-}
+}

src/__tests__/cli-client-commands.test.ts

@@ -961,20 +961,6 @@ function createStubClient(params: {
       list: async () => [],
       close: async () => ({ session: 'default', identifiers: { session: 'default' } }),
     },
-    simulators: {
-      ensure: async () => ({
-        udid: 'sim-1',
-        device: 'iPhone 16',
-        runtime: 'iOS-18-0',
-        created: false,
-        booted: true,
-        identifiers: {
-          deviceId: 'sim-1',
-          deviceName: 'iPhone 16',
-          udid: 'sim-1',
-        },
-      }),
-    },
     apps: {
       install: async () => ({
         app: 'Demo',

src/__tests__/remote-connection.test.ts

@@ -63,7 +63,6 @@ function createTestClient(
           identifiers: { session: 'adc-android' },
         })),
     }),
-    simulators: createThrowingMethodGroup<AgentDeviceClient['simulators']>(),
     apps: createThrowingMethodGroup<AgentDeviceClient['apps']>(),
     materializations: createThrowingMethodGroup<AgentDeviceClient['materializations']>(),
     leases: createThrowingMethodGroup<AgentDeviceClient['leases']>({

src/__tests__/runtime-admin-router.test.ts

@@ -39,13 +39,6 @@ test('admin runtime commands call typed backend primitives', async () => {
   const boot = await device.admin.boot({ target: { id: 'SIM-1' } });
   assert.equal(boot.kind, 'deviceBooted');
 
-  const simulator = await device.admin.ensureSimulator({
-    device: 'iPhone 16',
-    runtime: 'iOS 18',
-    boot: true,
-  });
-  assert.equal(simulator.udid, 'SIM-1');
-
   const installed = await device.admin.install({
     app: 'com.example.app',
     source: { kind: 'path', path: '/tmp/Example.app' },
@@ -67,7 +60,6 @@ test('admin runtime commands call typed backend primitives', async () => {
   assert.deepEqual(calls, [
     'listDevices',
     'bootDevice',
-    'ensureSimulator',
     'installApp',
     'reinstallApp',
     'installApp',
@@ -252,16 +244,6 @@ function createAdminBackend(
     bootDevice: async () => {
       calls.push('bootDevice');
     },
-    ensureSimulator: async (_context, options) => {
-      calls.push('ensureSimulator');
-      return {
-        udid: 'SIM-1',
-        device: options.device,
-        runtime: options.runtime ?? 'iOS 18',
-        created: false,
-        booted: true,
-      };
-    },
     installApp: async (_context, target) => {
       calls.push('installApp');
       onInstallSource?.(target.source);

src/backend.ts

@@ -258,22 +258,6 @@ export type BackendDeviceTarget = {
   headless?: boolean;
 };
 
-export type BackendEnsureSimulatorOptions = {
-  device: string;
-  runtime?: string;
-  boot?: boolean;
-  reuseExisting?: boolean;
-};
-
-export type BackendEnsureSimulatorResult = {
-  udid: string;
-  device: string;
-  runtime: string;
-  created: boolean;
-  booted: boolean;
-  simulatorSetPath?: string | null;
-};
-
 export type BackendInstallSource =
   | {
       kind: 'path';
@@ -549,10 +533,6 @@ export type AgentDeviceBackend = {
     context: BackendCommandContext,
     target?: BackendDeviceTarget,
   ): Promise<BackendActionResult>;
-  ensureSimulator?(
-    context: BackendCommandContext,
-    options: BackendEnsureSimulatorOptions,
-  ): Promise<BackendEnsureSimulatorResult>;
   resolveInstallSource?(
     context: BackendCommandContext,
     source: BackendInstallSource,

src/cli.ts

@@ -60,7 +60,6 @@ const REMOTE_MATERIALIZATION_DEFERRED_COMMANDS = new Set([
   'connection',
   'close',
   'disconnect',
-  'ensure-simulator',
   'metro',
   'session',
 ]);

src/cli/commands/connection-runtime.ts

@@ -22,7 +22,6 @@ const leaseDeferredCommands = new Set([
   'connection',
   'close',
   'disconnect',
-  'ensure-simulator',
   'metro',
   'session',
 ]);

src/cli/commands/ensure-simulator.ts

@@ -2,7 +2,6 @@ import type { CliFlags } from '../../utils/command-schema.ts';
 import type { AgentDeviceClient } from '../../client.ts';
 import { sessionCommand } from './session.ts';
 import { devicesCommand } from './devices.ts';
-import { ensureSimulatorCommand } from './ensure-simulator.ts';
 import { metroCommand } from './metro.ts';
 import { appsCommand } from './apps.ts';
 import { installCommand, reinstallCommand, installFromSourceCommand } from './install.ts';
@@ -25,7 +24,6 @@ const dedicatedCliCommandHandlers = {
   session: sessionCommand,
   devices: devicesCommand,
   apps: appsCommand,
-  'ensure-simulator': ensureSimulatorCommand,
   metro: metroCommand,
   install: installCommand,
   reinstall: reinstallCommand,

src/cli/commands/router.ts

@@ -28,7 +28,7 @@ import {
   stripUndefined,
 } from './utils/parsing.ts';
 
-export { readNullableString, readOptionalString, readRequiredString } from './utils/parsing.ts';
+export { readOptionalString, readRequiredString } from './utils/parsing.ts';
 
 const DEFAULT_SESSION_NAME = 'default';
 
@@ -249,9 +249,6 @@ export function buildFlags(options: InternalRequestOptions): CommandFlags {
     serial: options.serial,
     iosSimulatorDeviceSet: options.iosSimulatorDeviceSet,
     androidDeviceAllowlist: options.androidDeviceAllowlist,
-    runtime: options.simulatorRuntimeId,
-    boot: options.boot,
-    reuseExisting: options.reuseExisting,
     surface: options.surface,
     activity: options.activity,
     relaunch: options.relaunch,