fix: harden push payload path handling in session

Author: thymikee

src/daemon/handlers/session.ts

@@ -874,12 +874,22 @@ export async function handleSessionCommands(params: {
 function maybeResolvePushPayloadPath(payloadArg: string, cwd?: string): string {
   const trimmed = payloadArg.trim();
   const resolvedPath = SessionStore.expandHome(trimmed, cwd);
-  if (fs.existsSync(resolvedPath)) {
+  try {
     const stat = fs.statSync(resolvedPath);
     if (!stat.isFile()) {
       throw new AppError('INVALID_ARGS', `Push payload path is not a file: ${resolvedPath}`);
     }
     return resolvedPath;
+  } catch (error) {
+    const code = (error as NodeJS.ErrnoException).code;
+    if (code === 'EACCES' || code === 'EPERM') {
+      throw new AppError('INVALID_ARGS', `Push payload file is not readable: ${resolvedPath}`);
+    }
+    if (code && code !== 'ENOENT') {
+      throw new AppError('COMMAND_FAILED', `Unable to read push payload file: ${resolvedPath}`, {
+        cause: String(error),
+      });
+    }
   }
   if (looksLikeInlineJson(trimmed)) {
     return trimmed;

website/docs/docs/commands.md

@@ -128,7 +128,7 @@ agent-device push com.example.app '{"action":"com.example.app.PUSH","extras":{"t
 ```
 
 - `push <bundle|package> <payload.json|inline-json>` simulates push notification delivery.
-- iOS uses `xcrun simctl push` and requires an APNs-style JSON object payload.
+- iOS push simulation is simulator-only (`xcrun simctl push`) and requires an APNs-style JSON object payload.
 - Android uses `adb shell am broadcast` and accepts payload shape:
   `{"action":"<intent-action>","receiver":"<optional component>","extras":{"key":"value","flag":true,"count":3}}`.
 - Android extras support `string`, `boolean`, and `number` values.