chore: trim adaptive uptime diagnostics

Author: thymikee

src/platforms/ios/__tests__/runner-command-retry.test.ts

@@ -319,7 +319,6 @@ test('mutating commands include skipped readiness context in lost-response guida
     .mockRejectedValueOnce(
       new AppError('COMMAND_FAILED', 'fetch failed', {
         runnerReadinessPreflightSkipped: true,
-        runnerReadinessPreflightSkipFreshnessMs: 10_000,
         runnerReadinessPreflightSkipReason: 'recent_successful_response',
         runnerReadinessPreflightSkippedAgeMs: 4,
       }),
@@ -334,7 +333,6 @@ test('mutating commands include skipped readiness context in lost-response guida
       assert.equal(error.details?.readinessPreflightSkipped, true);
       assert.equal(error.details?.readinessPreflightSkipReason, 'recent_successful_response');
       assert.equal(error.details?.readinessPreflightSkippedAgeMs, 4);
-      assert.equal(error.details?.readinessPreflightSkipFreshnessMs, 10_000);
       assert.match(String(error.details?.hint), /skipped the uptime preflight/);
       assert.match(String(error.details?.hint), /status recovery confirmed/);
       assert.match(String(error.details?.hint), /snapshot -i/);

src/platforms/ios/runner-client.ts

@@ -44,7 +44,6 @@ type RunnerReadinessPreflightRecoveryDetails = {
   readinessPreflightSkipped?: boolean;
   readinessPreflightSkipReason?: string;
   readinessPreflightSkippedAgeMs?: number;
-  readinessPreflightSkipFreshnessMs?: number;
 };
 
 const RUNNER_STATUS_RECOVERY_TIMEOUT_MS = 3_000;
@@ -491,8 +490,6 @@ function readReadinessPreflightRecoveryDetails(
   if (reason !== undefined) details.readinessPreflightSkipReason = reason;
   const ageMs = readNumberDetail(error, 'runnerReadinessPreflightSkippedAgeMs');
   if (ageMs !== undefined) details.readinessPreflightSkippedAgeMs = ageMs;
-  const freshnessMs = readNumberDetail(error, 'runnerReadinessPreflightSkipFreshnessMs');
-  if (freshnessMs !== undefined) details.readinessPreflightSkipFreshnessMs = freshnessMs;
   return details;
 }
 

src/platforms/ios/runner-session.ts

@@ -58,13 +58,11 @@ type RunnerReadinessPreflightDecision =
         | 'conservative_command'
         | 'no_successful_response'
         | 'successful_response_stale';
-      freshnessMs: number;
       lastSuccessfulRunnerResponseAgeMs?: number;
     }
   | {
       action: 'skip';
       reason: 'recent_successful_response';
-      freshnessMs: number;
       lastSuccessfulRunnerResponseAgeMs: number;
     };
 
@@ -500,7 +498,6 @@ export async function executeRunnerCommandWithSession(
         {
           command: runnerCommand.command,
           commandId: runnerCommand.commandId,
-          freshnessMs: preflightDecision.freshnessMs,
           lastSuccessfulRunnerResponseAgeMs: preflightDecision.lastSuccessfulRunnerResponseAgeMs,
           reason: preflightDecision.reason,
           sessionReady: session.ready,
@@ -518,7 +515,6 @@ export async function executeRunnerCommandWithSession(
       data: {
         command: command.command,
         commandId: runnerCommand.commandId,
-        freshnessMs: preflightDecision.freshnessMs,
         lastSuccessfulRunnerResponseAgeMs: preflightDecision.lastSuccessfulRunnerResponseAgeMs,
         reason: preflightDecision.reason,
         sessionReady: session.ready,
@@ -597,37 +593,32 @@ function resolveRunnerReadinessPreflightDecision(
     return {
       action: 'run',
       reason: 'startup',
-      freshnessMs: RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS,
     };
   }
   if (command.command !== 'tap' && command.command !== 'tapSeries') {
     return {
       action: 'run',
       reason: 'conservative_command',
-      freshnessMs: RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS,
     };
   }
   const lastSuccessAt = session.lastSuccessfulRunnerResponseAtMs;
   if (lastSuccessAt === undefined) {
     return {
       action: 'run',
       reason: 'no_successful_response',
-      freshnessMs: RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS,
     };
   }
   const lastSuccessfulRunnerResponseAgeMs = Date.now() - lastSuccessAt;
   if (lastSuccessfulRunnerResponseAgeMs > RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS) {
     return {
       action: 'run',
       reason: 'successful_response_stale',
-      freshnessMs: RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS,
       lastSuccessfulRunnerResponseAgeMs,
     };
   }
   return {
     action: 'skip',
     reason: 'recent_successful_response',
-    freshnessMs: RUNNER_TAP_PREFLIGHT_SKIP_FRESHNESS_MS,
     lastSuccessfulRunnerResponseAgeMs,
   };
 }
@@ -672,7 +663,6 @@ function markRunnerSkippedReadinessPreflightError(
     {
       ...(appErr.details ?? {}),
       runnerReadinessPreflightSkipped: true,
-      runnerReadinessPreflightSkipFreshnessMs: decision.freshnessMs,
       runnerReadinessPreflightSkipReason: decision.reason,
       runnerReadinessPreflightSkippedAgeMs: decision.lastSuccessfulRunnerResponseAgeMs,
     },