chore: address snapshot session review

Author: thymikee

android-snapshot-helper/src/main/java/com/callstack/agentdevice/snapshothelper/SnapshotInstrumentation.java

@@ -23,6 +23,8 @@ public final class SnapshotInstrumentation extends Instrumentation {
   private static final String OUTPUT_FORMAT = "uiautomator-xml";
   private static final String HELPER_API_VERSION = "1";
   private static final int CHUNK_SIZE = 2 * 1024;
+  // Keep the default quiet window short: RN/animation-heavy apps often never become fully idle,
+  // and callers can still override this for alert-style flows that need a longer settle period.
   private static final long DEFAULT_WAIT_FOR_IDLE_TIMEOUT_MS = 25;
   private static final long DEFAULT_WAIT_FOR_IDLE_QUIET_MS = 25;
   private static final long DEFAULT_TIMEOUT_MS = 8_000;
@@ -334,6 +336,9 @@ private static void appendNode(
     Rect bounds = new Rect();
     node.getBoundsInScreen(bounds);
     xml.append("<node");
+    // Emit only fields consumed by the host parser. Extra boolean attrs made every node larger
+    // without affecting current snapshot semantics; add fields back here when TS starts reading
+    // them.
     appendAttribute(xml, "index", Integer.toString(nodeIndex));
     appendNonEmptyAttribute(xml, "text", node.getText());
     appendNonEmptyAttribute(xml, "resource-id", node.getViewIdResourceName());

docs/adr/0002-persistent-platform-helper-sessions.md

@@ -2,7 +2,7 @@
 
 ## Status
 
-Accepted
+Accepted (implementation pending)
 
 ## Context
 
@@ -47,7 +47,9 @@ The session pattern is:
 
 For Android snapshots, productize a persistent helper mode that keeps `UiAutomation` alive and
 serves fresh snapshot requests over an `adb forward` socket. Do not add snapshot result caching as
-part of that first step. The first reliable win is infrastructure reuse, not data reuse.
+part of that first step. The first reliable win is infrastructure reuse, not data reuse. The current
+PR only lands one-shot snapshot improvements and this decision record; the persistent Android
+session implementation is follow-up work.
 
 For iOS, keep the XCTest runner session as the reference implementation for lifecycle and
 invalidation behavior. Android does not need to copy iOS internals, but it should reuse the same

src/daemon/handlers/__tests__/session-open-runtime.test.ts

@@ -24,7 +24,6 @@ vi.mock('../../../platforms/ios/runner-client.ts', async (importOriginal) => {
   return {
     ...actual,
     prewarmIosRunnerSession: vi.fn(),
-    prewarmIosRunnerXctestrun: vi.fn(),
     stopIosRunnerSession: vi.fn(async () => {}),
   };
 });

src/daemon/handlers/__tests__/session.test.ts

@@ -18,7 +18,6 @@ vi.mock('../../../platforms/ios/runner-client.ts', async (importOriginal) => {
   return {
     ...actual,
     prewarmIosRunnerSession: vi.fn(),
-    prewarmIosRunnerXctestrun: vi.fn(),
     stopIosRunnerSession: vi.fn(async () => {}),
   };
 });
@@ -97,7 +96,6 @@ import { ensureDeviceReady } from '../../device-ready.ts';
 import { applyRuntimeHintsToApp, clearRuntimeHintsFromApp } from '../../runtime-hints.ts';
 import {
   prewarmIosRunnerSession,
-  prewarmIosRunnerXctestrun,
   stopIosRunnerSession,
 } from '../../../platforms/ios/runner-client.ts';
 import { runMacOsAlertAction } from '../../../platforms/ios/macos-helper.ts';
@@ -120,7 +118,6 @@ const mockEnsureDeviceReady = vi.mocked(ensureDeviceReady);
 const mockApplyRuntimeHints = vi.mocked(applyRuntimeHintsToApp);
 const mockClearRuntimeHints = vi.mocked(clearRuntimeHintsFromApp);
 const mockPrewarmIosRunnerSession = vi.mocked(prewarmIosRunnerSession);
-const mockPrewarmIosRunnerXctestrun = vi.mocked(prewarmIosRunnerXctestrun);
 const mockStopIosRunner = vi.mocked(stopIosRunnerSession);
 const mockDismissMacOsAlert = vi.mocked(runMacOsAlertAction);
 const mockSettleSimulator = vi.mocked(settleIosSimulator);
@@ -151,7 +148,6 @@ beforeEach(() => {
   mockClearRuntimeHints.mockReset();
   mockClearRuntimeHints.mockResolvedValue(undefined);
   mockPrewarmIosRunnerSession.mockReset();
-  mockPrewarmIosRunnerXctestrun.mockReset();
   mockStopIosRunner.mockReset();
   mockStopIosRunner.mockResolvedValue(undefined);
   mockDismissMacOsAlert.mockReset();
@@ -1962,7 +1958,6 @@ test('open custom URL on fresh iOS simulator session infers app bundle id from U
   expect(updated?.appName).toBe('rne://navigator-layout');
   expect(dispatchedContext?.appBundleId).toBe('org.reactnavigation.playground');
   expect(mockPrewarmIosRunnerSession).toHaveBeenCalledTimes(1);
-  expect(mockPrewarmIosRunnerXctestrun).not.toHaveBeenCalled();
 });
 
 test('open iOS app session prewarms runner session when app bundle id is known', async () => {
@@ -2001,7 +1996,6 @@ test('open iOS app session prewarms runner session when app bundle id is known',
     expect.objectContaining({ platform: 'ios', id: 'ios-device-1' }),
     expect.objectContaining({ logPath: expect.stringMatching(/daemon\.log$/) }),
   );
-  expect(mockPrewarmIosRunnerXctestrun).not.toHaveBeenCalled();
 });
 
 test('open iOS URL without app bundle id skips runner prewarm', async () => {
@@ -2035,7 +2029,6 @@ test('open iOS URL without app bundle id skips runner prewarm', async () => {
   expect(response).toBeTruthy();
   expect(response?.ok).toBe(true);
   expect(mockPrewarmIosRunnerSession).not.toHaveBeenCalled();
-  expect(mockPrewarmIosRunnerXctestrun).not.toHaveBeenCalled();
 });
 
 test('open web URL on iOS device session without active app falls back to Safari', async () => {

src/platforms/android/snapshot-helper-capture.ts

@@ -126,6 +126,8 @@ function buildAndroidSnapshotHelperArgs(
     '-e',
     'maxNodes',
     String(options.maxNodes),
+    // Default production snapshots use instrumentation status chunks. File output remains a
+    // fallback/testing transport for devices where status output cannot carry the payload.
     ...(options.outputPath ? ['-e', 'outputPath', options.outputPath] : []),
     ...(options.emitChunks !== undefined ? ['-e', 'emitChunks', String(options.emitChunks)] : []),
     options.runner,

src/platforms/ios/runner-client.ts

@@ -26,7 +26,6 @@ import {
   resolveAppleRunnerProvider,
   type AppleRunnerCommandOptions,
 } from './runner-provider.ts';
-import { ensureXctestrun } from './runner-xctestrun.ts';
 export {
   isRetryableRunnerError,
   resolveRunnerEarlyExitHint,
@@ -67,37 +66,6 @@ export async function runIosRunnerCommand(
   return provider.runCommand(device, command, options);
 }
 
-export function prewarmIosRunnerXctestrun(
-  device: DeviceInfo,
-  options: RunnerSessionOptions = {},
-): Promise<void> | undefined {
-  if (device.platform !== 'ios') {
-    return undefined;
-  }
-  if (hasScopedAppleRunnerProvider(device, { requestId: options.requestId })) {
-    emitDiagnostic({
-      level: 'debug',
-      phase: 'ios_runner_xctestrun_prewarm_skipped_scoped_provider',
-      data: { deviceId: device.id },
-    });
-    return undefined;
-  }
-  const prewarm = ensureXctestrun(device, options)
-    .then(() => {})
-    .catch((error: unknown) => {
-      emitDiagnostic({
-        level: 'warn',
-        phase: 'ios_runner_xctestrun_prewarm_failed',
-        data: {
-          deviceId: device.id,
-          error: error instanceof Error ? error.message : String(error),
-        },
-      });
-    });
-  void prewarm;
-  return prewarm;
-}
-
 export function prewarmIosRunnerSession(
   device: DeviceInfo,
   options: RunnerSessionOptions = {},