fix: preserve Android system dialog snapshots

Author: thymikee

src/platforms/android/__tests__/snapshot-content-recovery.test.ts

@@ -159,6 +159,47 @@ test('rejects a status-bar-only capture without window metadata', () => {
   expect(decision?.diagnostics.helperNonSystemMeaningfulNodeCount).toBe(0);
 });
 
+test('keeps a recognized system dialog without window metadata', () => {
+  const decision = classifyAndroidHelperContentRecovery(
+    helperXml([
+      node({
+        text: "Demo isn't responding",
+        resourceId: 'android:id/alertTitle',
+        packageName: 'com.android.systemui',
+        className: 'android.widget.TextView',
+      }),
+      node({
+        text: 'Do you want to close it?',
+        resourceId: 'android:id/message',
+        packageName: 'com.android.systemui',
+        className: 'android.widget.TextView',
+      }),
+      node({
+        text: 'Close app',
+        resourceId: 'android:id/button2',
+        packageName: 'com.android.systemui',
+        className: 'android.widget.Button',
+      }),
+      node({
+        text: 'Wait',
+        resourceId: 'android:id/button1',
+        packageName: 'com.android.systemui',
+        className: 'android.widget.Button',
+      }),
+    ]),
+    {
+      backend: 'android-helper',
+      nodeCount: 4,
+      rootPresent: true,
+      windowCount: 1,
+      captureMode: 'interactive-windows',
+    },
+    { foregroundAppPackage: 'com.pagerviewexample' },
+  );
+
+  expect(decision).toBeUndefined();
+});
+
 test('rejects system chrome inherited under an empty application window', () => {
   const decision = classifyAndroidHelperContentRecovery(
     helperXml([

src/platforms/android/alert-detection.ts

@@ -42,6 +42,15 @@ const ACCEPT_LABEL_PATTERN =
 const DISMISS_LABEL_PATTERN =
   /^(?:cancel|deny|don.t allow|don’t allow|not now|no|dismiss|close|close app|later|skip)$/i;
 
+export function classifyAndroidAlertIdentifier(
+  identifier: string | null,
+): 'button' | 'content' | undefined {
+  if (identifier === null) return undefined;
+  if (ANDROID_ALERT_BUTTON_ID_PATTERN.test(identifier)) return 'button';
+  if (ANDROID_ALERT_ID_PATTERN.test(identifier)) return 'content';
+  return undefined;
+}
+
 export function findAndroidAlertCandidate(nodes: RawSnapshotNode[]): AndroidAlertCandidate | null {
   const candidate = findAndroidAlertNodes(nodes);
   const candidateNodes = candidate.nodes;

src/platforms/android/snapshot-content-recovery.ts

@@ -1,5 +1,6 @@
 import type { AndroidSnapshotBackendMetadata } from './snapshot-types.ts';
 import { isAndroidInputMethodOwnedNode } from '../../contracts/android-input-ownership.ts';
+import { classifyAndroidAlertIdentifier } from './alert-detection.ts';
 import { androidUiNodes, type AndroidUiNodeMetadata } from './ui-hierarchy.ts';
 
 const ANDROID_WINDOW_TYPE_APPLICATION = 1;
@@ -48,6 +49,7 @@ export function classifyAndroidHelperContentRecovery(
     );
   }
 
+  if (hasRecognizedAndroidAlertSurface(summary)) return undefined;
   if (isForegroundAppContentHiddenByInputMethod(summary)) return undefined;
   if (isForegroundAppContentPoor(summary)) {
     return buildRecoveryDecision(
@@ -143,6 +145,10 @@ function isSystemWindowOnly(summary: AndroidHelperXmlSummary): boolean {
   );
 }
 
+function hasRecognizedAndroidAlertSurface(summary: AndroidHelperXmlSummary): boolean {
+  return summary.hasAlertButtonIdentifier && summary.hasAlertContentIdentifier;
+}
+
 function buildRecoveryDecision(
   summary: AndroidHelperXmlSummary,
   metadata: AndroidSnapshotBackendMetadata,
@@ -165,6 +171,8 @@ type AndroidHelperXmlSummary = {
   applicationMeaningfulNodeCount: number;
   nonSystemMeaningfulNodeCount: number;
   inputMethodMeaningfulNodeCount: number;
+  hasAlertButtonIdentifier: boolean;
+  hasAlertContentIdentifier: boolean;
   foregroundAppPackage?: string;
   foregroundAppMeaningfulNodeCount?: number;
   windowTypes: number[];
@@ -200,6 +208,8 @@ function createAndroidHelperXmlSummaryState(
     applicationMeaningfulNodeCount: 0,
     nonSystemMeaningfulNodeCount: 0,
     inputMethodMeaningfulNodeCount: 0,
+    hasAlertButtonIdentifier: false,
+    hasAlertContentIdentifier: false,
     ...(foregroundAppPackage !== undefined
       ? { foregroundAppPackage, foregroundAppMeaningfulNodeCount: 0 }
       : {}),
@@ -213,10 +223,20 @@ function recordAndroidHelperSummaryNode(
 ): void {
   summary.nodeCount += 1;
   if (node.packageName === ANDROID_SYSTEM_UI_PACKAGE) summary.systemUiNodeCount += 1;
+  if (node.visibleToUser !== false) recordAndroidAlertIdentifier(summary, node.resourceId);
   recordAndroidHelperWindowNode(summary, node);
   recordAndroidHelperMeaningfulNode(summary, node);
 }
 
+function recordAndroidAlertIdentifier(
+  summary: AndroidHelperXmlSummaryState,
+  resourceId: string | null,
+): void {
+  const kind = classifyAndroidAlertIdentifier(resourceId);
+  if (kind === 'button') summary.hasAlertButtonIdentifier = true;
+  if (kind === 'content') summary.hasAlertContentIdentifier = true;
+}
+
 function recordAndroidHelperWindowNode(
   summary: AndroidHelperXmlSummaryState,
   node: AndroidUiNodeMetadata,
@@ -275,6 +295,8 @@ function finalizeAndroidHelperXmlSummary(
     applicationMeaningfulNodeCount: summary.applicationMeaningfulNodeCount,
     nonSystemMeaningfulNodeCount: summary.nonSystemMeaningfulNodeCount,
     inputMethodMeaningfulNodeCount: summary.inputMethodMeaningfulNodeCount,
+    hasAlertButtonIdentifier: summary.hasAlertButtonIdentifier,
+    hasAlertContentIdentifier: summary.hasAlertContentIdentifier,
     ...(summary.foregroundAppPackage !== undefined
       ? {
           foregroundAppPackage: summary.foregroundAppPackage,