build: enable noUncheckedIndexedAccess

Author: thymikee

src/__tests__/cli-batch.test.ts

@@ -37,7 +37,7 @@ test('batch --steps parses JSON and forwards batchSteps only', async () => {
   ]);
   assert.equal(result.code, null);
   assert.equal(result.calls.length, 1);
-  const req = result.calls[0];
+  const req = result.calls[0]!;
   assert.equal(req.command, 'batch');
   assert.equal(req.session, 'sim');
   assert.equal(req.flags?.platform, 'ios');
@@ -53,7 +53,7 @@ test('batch --steps-file parses file payload', async () => {
   const result = await runCliCapture(['batch', '--steps-file', stepsPath, '--json']);
   assert.equal(result.code, null);
   assert.equal(result.calls.length, 1);
-  const req = result.calls[0];
+  const req = result.calls[0]!;
   assert.equal(req.command, 'batch');
   assert.equal((req.flags?.batchSteps ?? [])[0]?.command, 'wait');
 });

src/__tests__/client-companion-tunnel-worker.test.ts

@@ -121,7 +121,7 @@ function decodeWebSocketPayload(payload: Buffer, mask: Buffer | null): Buffer {
 
   const decoded = Buffer.from(payload);
   for (let index = 0; index < decoded.length; index += 1) {
-    decoded[index] ^= mask[index % 4];
+    decoded[index]! ^= mask[index % 4]!;
   }
   return decoded;
 }

src/__tests__/selectors-public.test.ts

@@ -37,7 +37,7 @@ const nodes: SnapshotNode[] = [
 
 test('public selector subpath exposes platform-aware matching helpers', () => {
   const chain: SelectorChain = parseSelectorChain('role=button label="Continue" visible=true');
-  const firstSelector: Selector = chain.selectors[0];
+  const firstSelector: Selector = chain.selectors[0]!;
   assert.equal(firstSelector.raw, 'role=button label="Continue" visible=true');
   assert.equal(tryParseSelectorChain(chain.raw)?.raw, chain.raw);
   assert.equal(isSelectorToken('visible=true'), true);
@@ -55,8 +55,8 @@ test('public selector subpath exposes platform-aware matching helpers', () => {
   });
   assert.equal(resolved?.node.ref, 'e1');
 
-  assert.equal(isNodeVisible(nodes[0]), true);
-  assert.equal(isNodeEditable(nodes[1], 'android'), true);
+  assert.equal(isNodeVisible(nodes[0]!), true);
+  assert.equal(isNodeEditable(nodes[1]!, 'android'), true);
 });
 
 test('public selector diagnostics format failures', () => {

src/__tests__/upload-client.test.ts

@@ -427,7 +427,7 @@ test('uploadArtifact disables macOS AppleDouble entries when archiving app bundl
       (cmd, args, options) => {
         if (cmd !== 'tar') return undefined;
         tarEnv = options.env;
-        const archivePath = args[1];
+        const archivePath = args[1]!;
         assert.equal(args[0], 'czf');
         assert.equal(typeof archivePath, 'string');
         fs.writeFileSync(archivePath, 'fake-archive');

src/cli.ts

@@ -481,6 +481,7 @@ function hasExplicitMetroRuntimeOverrides(explicitFlagKeys: Set<FlagKey>): boole
 function guessSessionFromArgv(argv: string[]): string | null {
   for (let i = 0; i < argv.length; i += 1) {
     const token = argv[i];
+    if (token === undefined) continue;
     if (token.startsWith('--session=')) {
       const inline = token.slice('--session='.length).trim();
       return inline.length > 0 ? inline : null;

src/command-codecs/targets.ts

@@ -60,14 +60,19 @@ export function elementTargetToPositionals(options: ElementTarget): string[] {
 }
 
 export function readFillTargetFromPositionals(positionals: string[]): DecodedFillTarget {
-  if (positionals[0]?.startsWith('@')) {
+  const ref = positionals[0];
+  if (ref?.startsWith('@')) {
     const text =
       positionals.length >= 3 ? positionals.slice(2).join(' ') : positionals.slice(1).join(' ');
+    const maybeLabel = positionals[1];
     return {
       kind: 'ref',
       target: {
-        ref: positionals[0],
-        label: positionals.length >= 3 ? optionalTrimmedText([positionals[1]]) : undefined,
+        ref,
+        label:
+          positionals.length >= 3 && maybeLabel !== undefined
+            ? optionalTrimmedText([maybeLabel])
+            : undefined,
       },
       text,
     };

src/command-codecs/wait.ts

@@ -67,19 +67,21 @@ export function waitOptionsToPositionals(options: WaitCommandOptions): string[]
 
 export function parseWaitPositionals(args: string[]): WaitParsed | null {
   if (args.length === 0) return null;
+  const firstArg = args[0];
+  if (firstArg === undefined) return null;
 
-  const sleepMs = parseTimeout(args[0]);
+  const sleepMs = parseTimeout(firstArg);
   if (sleepMs !== null) return { kind: 'sleep', durationMs: sleepMs };
 
-  if (args[0] === 'text') {
+  if (firstArg === 'text') {
     const timeoutMs = parseTimeout(args[args.length - 1]);
     const text = timeoutMs !== null ? args.slice(1, -1).join(' ') : args.slice(1).join(' ');
     return { kind: 'text', text: text.trim(), timeoutMs };
   }
 
-  if (args[0].startsWith('@')) {
+  if (firstArg.startsWith('@')) {
     const timeoutMs = parseTimeout(args[args.length - 1]);
-    return { kind: 'ref', rawRef: args[0], timeoutMs };
+    return { kind: 'ref', rawRef: firstArg, timeoutMs };
   }
 
   const timeoutMs = parseTimeout(args[args.length - 1]);

src/commands/interaction-targeting.ts

@@ -80,7 +80,9 @@ function findPreferredActionableDescendant(
     if (sameRectChildren.length !== 1) {
       break;
     }
-    current = sameRectChildren[0];
+    const next = sameRectChildren[0];
+    if (next === undefined) break;
+    current = next;
   }
 
   return current === node ? null : current;

src/commands/react-native/overlay.ts

@@ -177,15 +177,17 @@ function actionFromDismissNode(node: SnapshotNode): ReactNativeOverlayDismissTar
 function chooseCollapsedWarningNode(nodes: SnapshotNode[]): SnapshotNode | null {
   const withRect = nodes.filter((node) => node.rect);
   if (withRect.length === 0) return null;
-  return withRect.sort((a, b) => {
-    const aHittable = a.hittable === true ? 1 : 0;
-    const bHittable = b.hittable === true ? 1 : 0;
-    if (aHittable !== bHittable) return bHittable - aHittable;
-    const aWidth = a.rect?.width ?? 0;
-    const bWidth = b.rect?.width ?? 0;
-    if (aWidth !== bWidth) return bWidth - aWidth;
-    return (b.rect?.y ?? 0) - (a.rect?.y ?? 0);
-  })[0];
+  return (
+    withRect.sort((a, b) => {
+      const aHittable = a.hittable === true ? 1 : 0;
+      const bHittable = b.hittable === true ? 1 : 0;
+      if (aHittable !== bHittable) return bHittable - aHittable;
+      const aWidth = a.rect?.width ?? 0;
+      const bWidth = b.rect?.width ?? 0;
+      if (aWidth !== bWidth) return bWidth - aWidth;
+      return (b.rect?.y ?? 0) - (a.rect?.y ?? 0);
+    })[0] ?? null
+  );
 }
 
 function collapsedBannerClosePoint(node: SnapshotNode): Point {

src/compat/maestro/support.ts

@@ -114,7 +114,7 @@ export function requireStringValue(command: string, value: unknown): string {
 
 export function resolveMaestroString(value: string, context: MaestroParseContext): string {
   return value.replace(/\$\{([A-Za-z_][A-Za-z0-9_]*)\}/g, (match, key: string) => {
-    return Object.prototype.hasOwnProperty.call(context.env, key) ? context.env[key] : match;
+    return context.env[key] ?? match;
   });
 }