fix: surface session state directory

Author: thymikee

skills/dogfood/SKILL.md

@@ -22,6 +22,6 @@ Read current CLI guidance:
 agent-device help dogfood
 ```
 
-Loop: open named session -> snapshot -i + screenshot -> explore flows -> capture evidence per issue -> close.
+Loop: open app -> snapshot -i + screenshot -> explore flows -> capture evidence per issue -> close.
 
 Target app is required; infer platform or ask. Findings must come from runtime behavior, not source reads. Let `help dogfood` provide exact report shape, evidence commands, and current workflow guidance.

src/cli.ts

@@ -215,7 +215,7 @@ export async function runCli(argv: string[], deps: CliDeps = DEFAULT_CLI_DEPS):
           currentFlags: CliFlags,
           runtime: SessionRuntimeHints | undefined,
         ): AgentDeviceClientConfig => ({
-          session: currentFlags.session ?? sessionName,
+          session: currentFlags.session,
           requestId,
           stateDir: currentFlags.stateDir,
           daemonBaseUrl: currentFlags.daemonBaseUrl,
@@ -231,7 +231,6 @@ export async function runCli(argv: string[], deps: CliDeps = DEFAULT_CLI_DEPS):
           lockPolicy: binding.lockPolicy,
           lockPlatform: binding.defaultPlatform,
           cwd: process.cwd(),
-          sessionExplicit: currentFlags.session !== undefined,
           debug: debugOutputEnabled,
         });
         let parsedBatchSteps: BatchStep[] | undefined;

src/client-normalizers.ts

@@ -333,7 +333,7 @@ export function buildMeta(options: InternalRequestOptions): DaemonRequest['meta'
   return stripUndefined({
     requestId: options.requestId,
     cwd: options.cwd,
-    sessionExplicit: options.sessionExplicit ?? options.session !== undefined,
+    sessionExplicit: options.session !== undefined,
     debug: options.debug,
     lockPolicy: options.lockPolicy,
     lockPlatform: options.lockPlatform,

src/client-shared.ts

@@ -140,6 +140,7 @@ export function serializeOpenResult(result: AppOpenResult): Record<string, unkno
   return withSuccessText(
     {
       session: result.session,
+      ...(result.sessionStateDir ? { sessionStateDir: result.sessionStateDir } : {}),
       ...(result.appName ? { appName: result.appName } : {}),
       ...(result.appBundleId ? { appBundleId: result.appBundleId } : {}),
       ...(result.startup ? { startup: result.startup } : {}),

src/client-types.ts

@@ -57,7 +57,6 @@ export type AgentDeviceClientConfig = {
   leaseBackend?: LeaseBackend;
   runtime?: SessionRuntimeHints;
   cwd?: string;
-  sessionExplicit?: boolean;
   debug?: boolean;
 };
 
@@ -77,7 +76,6 @@ export type AgentDeviceRequestOverrides = Pick<
   | 'leaseId'
   | 'leaseBackend'
   | 'cwd'
-  | 'sessionExplicit'
   | 'debug'
 >;
 
@@ -186,6 +184,7 @@ export type AppOpenOptions = AgentDeviceRequestOverrides &
 
 export type AppOpenResult = {
   session: string;
+  sessionStateDir?: string;
   appName?: string;
   appBundleId?: string;
   appId?: string;

src/client.ts

@@ -151,6 +151,7 @@ export function createAgentDeviceClient(
         const appId = appBundleId;
         return {
           session,
+          sessionStateDir: readOptionalString(data, 'sessionStateDir'),
           appName: readOptionalString(data, 'appName'),
           appBundleId,
           appId,

src/commands/__tests__/client-output.test.ts

@@ -1,7 +1,39 @@
 import { describe, expect, test } from 'vitest';
-import { recordCliOutput } from '../client-output.ts';
+import { openCliOutput, recordCliOutput } from '../client-output.ts';
+
+describe('openCliOutput', () => {
+  test('prints session state directory on a second line', () => {
+    const output = openCliOutput({
+      session: 'default',
+      sessionStateDir: '/tmp/agent-device/sessions/cwd_123_default',
+      identifiers: { session: 'default' },
+    });
+
+    expect(output.text).toBe(
+      ['Opened: default', 'Session state: /tmp/agent-device/sessions/cwd_123_default'].join('\n'),
+    );
+    expect(output.data).toMatchObject({
+      session: 'default',
+      sessionStateDir: '/tmp/agent-device/sessions/cwd_123_default',
+    });
+  });
+});
 
 describe('recordCliOutput', () => {
+  test('prints session state directory for record-created sessions', () => {
+    const output = recordCliOutput({
+      recording: 'started',
+      outPath: '/tmp/recording.mp4',
+      sessionStateDir: '/tmp/agent-device/sessions/cwd_123_default',
+    });
+
+    expect(output.text).toBe(
+      ['/tmp/recording.mp4', 'Session state: /tmp/agent-device/sessions/cwd_123_default'].join(
+        '\n',
+      ),
+    );
+  });
+
   test('prints chunked Android recording paths clearly for human stdout', () => {
     const output = recordCliOutput({
       recording: 'stopped',

src/commands/client-output.ts

@@ -56,7 +56,12 @@ export function sessionCliOutput(result: { sessions: AgentDeviceSession[] }): Cl
 }
 
 export function openCliOutput(result: AppOpenResult): CliOutput {
-  return messageOutput(serializeOpenResult(result));
+  const data = serializeOpenResult(result);
+  const lines = [readCommandMessage(data)].filter((line): line is string => Boolean(line));
+  if (typeof data.sessionStateDir === 'string') {
+    lines.push(`Session state: ${data.sessionStateDir}`);
+  }
+  return { data, text: lines.join('\n') || null };
 }
 
 export function closeCliOutput(result: AppCloseResult | SessionCloseResult): CliOutput {
@@ -207,6 +212,8 @@ function defaultCommandCliOutput(result: CommandRequestResult): CliOutput {
 function formatRecordSingleOutput(data: Record<string, unknown>, outPath: string): string {
   const lines: string[] = [];
   if (outPath) lines.push(outPath);
+  if (typeof data.sessionStateDir === 'string')
+    lines.push(`Session state: ${data.sessionStateDir}`);
   if (typeof data.warning === 'string') lines.push(`Warning: ${data.warning}`);
   if (typeof data.overlayWarning === 'string')
     lines.push(`Overlay warning: ${data.overlayWarning}`);

src/daemon/__tests__/request-router-open.test.ts

@@ -1,4 +1,5 @@
 import { test, expect, vi, beforeEach } from 'vitest';
+import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
 import { getResolveTargetDeviceMock } from './request-router-dispatch-mocks.ts';
@@ -57,6 +58,23 @@ beforeEach(() => {
   mockEnsureDeviceReady.mockResolvedValue(undefined);
 });
 
+test('open returns and creates the session state directory', async () => {
+  const sessionStore = makeSessionStore('agent-device-router-open-');
+  const device = makeIosDevice('SIM-STATE');
+  mockResolveTargetDevice.mockResolvedValue(device);
+
+  const handler = createOpenHandler(sessionStore);
+
+  const response = await handler(openRequest('session-a', { platform: 'ios' }, 'req-open-state'));
+
+  expect(response.ok).toBe(true);
+  if (response.ok) {
+    expect(response.data?.session).toBe('session-a');
+    expect(response.data?.sessionStateDir).toEqual(expect.stringContaining('session-a'));
+    expect(fs.existsSync(String(response.data?.sessionStateDir))).toBe(true);
+  }
+});
+
 test('router serializes same-device open requests before first session creation finishes', async () => {
   const sessionStore = makeSessionStore('agent-device-router-open-');
   const sameDevice = makeIosDevice('SIM-001');

src/daemon/handlers/record-trace-recording.ts

@@ -286,6 +286,7 @@ async function startRecording(params: {
 
   activeSession.recording = recording;
   sessionStore.set(sessionName, activeSession);
+  const sessionStateDir = sessionStore.ensureSessionDir(sessionName);
   sessionStore.recordAction(activeSession, {
     command: req.command,
     positionals: req.positionals ?? [],
@@ -298,6 +299,7 @@ async function startRecording(params: {
     data: {
       recording: 'started',
       outPath: recording.clientOutPath ?? outPath,
+      sessionStateDir,
       showTouches: recording.showTouches,
     },
   };