chore: remove trigger command aliases

Author: thymikee

README.md

@@ -149,8 +149,6 @@ agent-device scrollintoview @e42
 - `press` (alias: `click`), `focus`, `type`, `fill`, `long-press`, `swipe`, `scroll`, `scrollintoview`, `pinch`, `is`
 - `alert`, `wait`, `screenshot`
 - `trigger-app-event <event> [payloadJson]`
-- `trigger-screenshot-notification` (alias: `trigger-screenshot`)
-- `trigger-memory-warning`, `trigger-device-shake`
 - `trace start`, `trace stop`
 - `logs path`, `logs start`, `logs stop`, `logs clear`, `logs clear --restart`, `logs doctor`, `logs mark` (session app log file for grep; iOS simulator + iOS device + Android)
 - `clipboard read`, `clipboard write <text>` (iOS simulator + Android)
@@ -187,18 +185,11 @@ Payload notes:
 App event triggers (app hook):
 
 ```bash
-# Generic app event trigger
 agent-device trigger-app-event screenshot_taken '{"source":"qa"}'
-
-# Convenience aliases
-agent-device trigger-screenshot-notification
-agent-device trigger-screenshot
-agent-device trigger-memory-warning
-agent-device trigger-device-shake
 ```
 
-- `trigger-*` commands dispatch an app event via deep link and require an app-side test/debug hook.
-- `trigger-*` commands require either an active session or explicit device selectors (`--platform`, `--device`, `--udid`, `--serial`).
+- `trigger-app-event` dispatches an app event via deep link and requires an app-side test/debug hook.
+- `trigger-app-event` requires either an active session or explicit device selectors (`--platform`, `--device`, `--udid`, `--serial`).
 - On iOS physical devices, custom-scheme deep links require active app context (open the app in-session first).
 - Configure one of:
   - `AGENT_DEVICE_APP_EVENT_URL_TEMPLATE`

skills/agent-device/SKILL.md

@@ -142,7 +142,6 @@ agent-device perf --json
 agent-device network dump [limit] [summary|headers|body|all]
 agent-device push <bundle|package> <payload.json|inline-json>
 agent-device trigger-app-event screenshot_taken '{"source":"qa"}'
-agent-device trigger-screenshot-notification
 agent-device get text @e1
 agent-device screenshot out.png
 agent-device settings permission grant notifications
@@ -176,8 +175,8 @@ agent-device batch --steps-file /tmp/batch-steps.json --json
 - `push` simulates notification delivery:
   - iOS simulator uses APNs-style payload JSON.
   - Android uses broadcast action + typed extras (string/boolean/number).
-- `trigger-app-event` and `trigger-*` aliases require app-defined deep-link hooks and URL template configuration (`AGENT_DEVICE_APP_EVENT_URL_TEMPLATE` or platform-specific variants).
-- `trigger-*` commands require an active session or explicit selectors (`--platform`, `--device`, `--udid`, `--serial`); on iOS physical devices, custom-scheme triggers require active app context.
+- `trigger-app-event` requires app-defined deep-link hooks and URL template configuration (`AGENT_DEVICE_APP_EVENT_URL_TEMPLATE` or platform-specific variants).
+- `trigger-app-event` requires an active session or explicit selectors (`--platform`, `--device`, `--udid`, `--serial`); on iOS physical devices, custom-scheme triggers require active app context.
 - Canonical trigger behavior and caveats are documented in [`website/docs/docs/commands.md`](../../website/docs/docs/commands.md) under **App event triggers**.
 - Permission settings are app-scoped and require an active session app:
   `settings permission <grant|deny|reset> <camera|microphone|photos|contacts|notifications> [full|limited]`

src/core/__tests__/app-events.test.ts

@@ -1,21 +1,8 @@
 import test from 'node:test';
 import assert from 'node:assert/strict';
-import { parseTriggerAppEventArgs, normalizeTriggerAliasCommand } from '../app-events.ts';
+import { parseTriggerAppEventArgs } from '../app-events.ts';
 import { AppError } from '../../utils/errors.ts';
 
-test('normalizeTriggerAliasCommand maps aliases to trigger-app-event', () => {
-  const normalized = normalizeTriggerAliasCommand('trigger-screenshot-notification', []);
-  assert.equal(normalized.command, 'trigger-app-event');
-  assert.deepEqual(normalized.positionals, ['screenshot_taken']);
-});
-
-test('normalizeTriggerAliasCommand rejects alias arguments', () => {
-  assert.throws(
-    () => normalizeTriggerAliasCommand('trigger-device-shake', ['extra']),
-    (error) => error instanceof AppError && error.code === 'INVALID_ARGS',
-  );
-});
-
 test('parseTriggerAppEventArgs validates event name format', () => {
   assert.throws(
     () => parseTriggerAppEventArgs(['bad event']),

src/core/app-events.ts

@@ -1,33 +1,12 @@
 import type { DeviceInfo } from '../utils/device.ts';
 import { AppError } from '../utils/errors.ts';
 
-const APP_EVENT_ALIAS_TO_NAME = {
-  'trigger-screenshot': 'screenshot_taken',
-  'trigger-screenshot-notification': 'screenshot_taken',
-  'trigger-memory-warning': 'memory_warning',
-  'trigger-device-shake': 'device_shake',
-} as const;
-
 const APP_EVENT_NAME_PATTERN = /^[A-Za-z0-9_.:-]{1,64}$/;
 const MAX_APP_EVENT_PAYLOAD_BYTES = 8 * 1024;
 const MAX_APP_EVENT_URL_LENGTH = 4 * 1024;
 
 type AppEventPayload = Record<string, unknown> | undefined;
 
-export function normalizeTriggerAliasCommand(
-  command: string,
-  positionals: string[],
-): { command: string; positionals: string[] } {
-  const eventName = APP_EVENT_ALIAS_TO_NAME[command as keyof typeof APP_EVENT_ALIAS_TO_NAME];
-  if (!eventName) {
-    return { command, positionals };
-  }
-  if (positionals.length > 0) {
-    throw new AppError('INVALID_ARGS', `${command} does not accept positional arguments`);
-  }
-  return { command: 'trigger-app-event', positionals: [eventName] };
-}
-
 export function parseTriggerAppEventArgs(positionals: string[]): {
   eventName: string;
   payload: AppEventPayload;

src/daemon.ts

@@ -5,7 +5,6 @@ import path from 'node:path';
 import crypto from 'node:crypto';
 import { dispatchCommand, type CommandFlags } from './core/dispatch.ts';
 import { isCommandSupportedOnDevice } from './core/capabilities.ts';
-import { normalizeTriggerAliasCommand } from './core/app-events.ts';
 import { asAppError, AppError, normalizeError } from './utils/errors.ts';
 import { findProjectRoot, readVersion } from './utils/version.ts';
 import { abortAllIosRunnerSessions, stopAllIosRunnerSessions } from './platforms/ios/runner-client.ts';
@@ -279,30 +278,10 @@ function finalizeDaemonResponse(response: DaemonResponse): DaemonResponse {
 }
 
 function normalizeAliasedCommands(req: DaemonRequest): DaemonRequest {
-  let normalizedReq = req;
-  if (normalizedReq.command === 'click') {
-    normalizedReq = { ...normalizedReq, command: 'press' };
+  if (req.command === 'click') {
+    return { ...req, command: 'press' };
   }
-  const normalizedTrigger = normalizeTriggerAliasCommand(
-    normalizedReq.command,
-    normalizedReq.positionals ?? [],
-  );
-  if (
-    normalizedTrigger.command !== normalizedReq.command
-    || !areSamePositionals(normalizedTrigger.positionals, normalizedReq.positionals ?? [])
-  ) {
-    normalizedReq = {
-      ...normalizedReq,
-      command: normalizedTrigger.command,
-      positionals: normalizedTrigger.positionals,
-    };
-  }
-  return normalizedReq;
-}
-
-function areSamePositionals(left: string[], right: string[]): boolean {
-  if (left.length !== right.length) return false;
-  return left.every((entry, index) => entry === right[index]);
+  return req;
 }
 
 function writeInfo(ports: { socketPort?: number; httpPort?: number }): void {

src/utils/__tests__/args.test.ts

@@ -485,8 +485,7 @@ test('settings usage documents canonical faceid states', () => {
   assert.doesNotMatch(help, /validate\|unvalidate/);
 });
 
-test('trigger-screenshot-notification usage is documented', () => {
+test('removed trigger aliases are no longer documented as commands', () => {
   const help = usageForCommand('trigger-screenshot-notification');
-  if (help === null) throw new Error('Expected command help text');
-  assert.match(help, /Trigger app-defined screenshot notification hook/);
+  assert.equal(help, null);
 });

src/utils/command-schema.ts

@@ -650,30 +650,6 @@ const COMMAND_SCHEMAS: Record<string, CommandSchema> = {
     positionalArgs: ['event', 'payloadJson?'],
     allowedFlags: [],
   },
-  'trigger-screenshot': {
-    description: 'Trigger app-defined screenshot event hook',
-    positionalArgs: [],
-    allowedFlags: [],
-    skipCapabilityCheck: true,
-  },
-  'trigger-screenshot-notification': {
-    description: 'Trigger app-defined screenshot notification hook',
-    positionalArgs: [],
-    allowedFlags: [],
-    skipCapabilityCheck: true,
-  },
-  'trigger-memory-warning': {
-    description: 'Trigger app-defined memory warning event hook',
-    positionalArgs: [],
-    allowedFlags: [],
-    skipCapabilityCheck: true,
-  },
-  'trigger-device-shake': {
-    description: 'Trigger app-defined device shake event hook',
-    positionalArgs: [],
-    allowedFlags: [],
-    skipCapabilityCheck: true,
-  },
   record: {
     usageOverride: 'record start [path] [--fps <n>] | record stop',
     description: 'Start/stop screen recording',

website/docs/docs/commands.md

@@ -176,19 +176,11 @@ agent-device push com.example.app '{"action":"com.example.app.PUSH","extras":{"t
 
 ```bash
 agent-device trigger-app-event screenshot_taken '{"source":"qa"}'
-agent-device trigger-screenshot-notification
-agent-device trigger-screenshot
-agent-device trigger-memory-warning
-agent-device trigger-device-shake
 ```
 
 - `trigger-app-event <event> [payloadJson]` dispatches app-defined events via deep link.
-- `trigger-*` commands require either an active session or explicit device selectors (`--platform`, `--device`, `--udid`, `--serial`).
+- `trigger-app-event` requires either an active session or explicit device selectors (`--platform`, `--device`, `--udid`, `--serial`).
 - On iOS physical devices, custom-scheme deep links require active app context (open app first in the session).
-- Convenience aliases:
-  - `trigger-screenshot-notification` / `trigger-screenshot` -> `screenshot_taken`
-  - `trigger-memory-warning` -> `memory_warning`
-  - `trigger-device-shake` -> `device_shake`
 - Configure one of:
   - `AGENT_DEVICE_APP_EVENT_URL_TEMPLATE`
   - `AGENT_DEVICE_IOS_APP_EVENT_URL_TEMPLATE`

website/docs/docs/introduction.md

@@ -31,7 +31,7 @@ For exploratory QA and bug-hunting workflows, see `skills/dogfood/SKILL.md` in t
   - Physical-device recording requires an active app session context (`open <app>` first).
   - Physical-device recording defaults to uncapped (max available) FPS and supports `--fps` caps.
 - Android supports the same core interaction set, plus `push` notification simulation and `clipboard read/write` via adb shell commands.
-- App-event triggers are available on iOS and Android through app-defined deep-link hooks (`trigger-app-event` and trigger aliases), using active session context or explicit device selectors.
+- App-event triggers are available on iOS and Android through app-defined deep-link hooks (`trigger-app-event`), using active session context or explicit device selectors.
 
 ## Architecture (high level)