fix: require tracked app for ios snapshots

Author: thymikee

src/daemon/handlers/__tests__/snapshot-handler.test.ts

@@ -336,6 +336,68 @@ test('snapshot rejects @ref scope without existing session snapshot', async () =
   }
 });
 
+test('snapshot on iOS rejects sessions without a tracked app', async () => {
+  const sessionStore = makeSessionStore();
+  const sessionName = 'ios-sim-no-app';
+  sessionStore.set(sessionName, makeSession(sessionName, iosSimulatorDevice));
+
+  const response = await handleSnapshotCommands({
+    req: {
+      token: 't',
+      session: sessionName,
+      command: 'snapshot',
+      positionals: [],
+      flags: {},
+    },
+    sessionName,
+    logPath: '/tmp/daemon.log',
+    sessionStore,
+  });
+
+  expect(response?.ok).toBe(false);
+  if (response?.ok === false) {
+    expect(response.error.code).toBe('SESSION_NOT_FOUND');
+    expect(response.error.message).toMatch(/iOS snapshot requires an active app session/i);
+  }
+  expect(mockDispatch).not.toHaveBeenCalled();
+});
+
+test('snapshot on iOS runs when the session tracks an app', async () => {
+  const sessionStore = makeSessionStore();
+  const sessionName = 'ios-sim-app';
+  sessionStore.set(sessionName, {
+    ...makeSession(sessionName, iosSimulatorDevice),
+    appBundleId: 'org.reactnavigation.playground',
+  });
+  mockDispatch.mockResolvedValue({
+    nodes: [{ index: 0, depth: 0, type: 'Button', label: 'Home' }],
+    truncated: false,
+    backend: 'ios',
+  });
+
+  const response = await handleSnapshotCommands({
+    req: {
+      token: 't',
+      session: sessionName,
+      command: 'snapshot',
+      positionals: [],
+      flags: {},
+    },
+    sessionName,
+    logPath: '/tmp/daemon.log',
+    sessionStore,
+  });
+
+  expect(response?.ok).toBe(true);
+  expect(mockDispatch).toHaveBeenCalledWith(
+    iosSimulatorDevice,
+    'snapshot',
+    [],
+    undefined,
+    expect.objectContaining({ appBundleId: 'org.reactnavigation.playground' }),
+  );
+});
+
 test('snapshot surfaces filtered-to-zero Android guidance for interactive snapshots', async () => {
   const sessionStore = makeSessionStore();
   const sessionName = 'android-empty-interactive';

src/daemon/snapshot-runtime.ts

@@ -115,6 +115,8 @@ async function dispatchSnapshotRuntimeCommand(
   }
   const resolvedScope = resolveSnapshotScope(req.flags?.snapshotScope, session);
   if (!resolvedScope.ok) return resolvedScope;
+  const iosAppSessionGuard = requireIosAppSessionForSnapshot(params.command, session, device);
+  if (iosAppSessionGuard) return iosAppSessionGuard;
 
   return await withSessionlessRunnerCleanup(session, device, async () => {
     const runtime = createSnapshotRuntime({
@@ -158,6 +160,20 @@ async function dispatchSnapshotRuntimeCommand(
   });
 }
 
+function requireIosAppSessionForSnapshot(
+  command: 'snapshot' | 'diff',
+  session: SessionState | undefined,
+  device: SessionState['device'],
+): DaemonResponse | null {
+  if (device.platform !== 'ios' || session?.appBundleId) {
+    return null;
+  }
+  return errorResponse(
+    'SESSION_NOT_FOUND',
+    `iOS ${command} requires an active app session on the target device. Run open first (for example: open --session ${session?.name ?? 'sim'} --platform ios --device "<name>" <app>).`,
+  );
+}
+
 function createSnapshotRuntime(params: {
   req: DaemonRequest;
   sessionName: string;