refactor: keep ios runner status off main thread

Author: thymikee

ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+CommandExecution.swift

@@ -27,7 +27,7 @@ extension RunnerTests {
 
   func execute(command: Command) throws -> Response {
     if command.command == .status {
-      return try executeDispatched(command: command)
+      return executeStatus(command: command)
     }
     commandJournal.accept(command: command)
     commandJournal.start(command: command)
@@ -41,6 +41,17 @@ extension RunnerTests {
     }
   }
 
+  private func executeStatus(command: Command) -> Response {
+    guard
+      let statusCommandId = command.statusCommandId?
+        .trimmingCharacters(in: .whitespacesAndNewlines),
+      !statusCommandId.isEmpty
+    else {
+      return Response(ok: false, error: ErrorPayload(message: "status requires statusCommandId"))
+    }
+    return Response(ok: true, data: commandJournal.status(commandId: statusCommandId))
+  }
+
   private func executeDispatched(command: Command) throws -> Response {
     if Thread.isMainThread {
       return try executeOnMainSafely(command: command)
@@ -200,14 +211,7 @@ extension RunnerTests {
 
     switch command.command {
     case .status:
-      guard
-        let statusCommandId = command.statusCommandId?
-          .trimmingCharacters(in: .whitespacesAndNewlines),
-        !statusCommandId.isEmpty
-      else {
-        return Response(ok: false, error: ErrorPayload(message: "status requires statusCommandId"))
-      }
-      return Response(ok: true, data: commandJournal.status(commandId: statusCommandId))
+      return executeStatus(command: command)
     case .shutdown:
       stopRecordingIfNeeded()
       return Response(ok: true, data: DataPayload(message: "shutdown"))

ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+CommandJournal.swift

@@ -1,6 +1,7 @@
 import Foundation
 
 enum RunnerCommandLifecycleState: String {
+  case notAccepted
   case accepted
   case started
   case completed
@@ -66,13 +67,16 @@ final class RunnerCommandJournal {
 
   func status(commandId: String) -> DataPayload {
     guard let normalized = normalizedCommandId(commandId) else {
-      return DataPayload(lifecycleState: "notAccepted")
+      return DataPayload(lifecycleState: RunnerCommandLifecycleState.notAccepted.rawValue)
     }
     lock.lock()
     let entry = entries[normalized]
     lock.unlock()
     guard let entry else {
-      return DataPayload(commandId: normalized, lifecycleState: "notAccepted")
+      return DataPayload(
+        commandId: normalized,
+        lifecycleState: RunnerCommandLifecycleState.notAccepted.rawValue
+      )
     }
     return DataPayload(
       commandId: entry.commandId,

src/platforms/ios/__tests__/runner-client.test.ts

@@ -389,6 +389,12 @@ test('withRunnerCommandId replaces blank command ids', () => {
   assert.match(command.commandId ?? '', /^runner-/);
 });
 
+test('withRunnerCommandId preserves existing command ids', () => {
+  const command = withRunnerCommandId({ command: 'uptime', commandId: 'runner-existing' });
+
+  assert.deepEqual(command, { command: 'uptime', commandId: 'runner-existing' });
+});
+
 test('withRunnerCommandId does not add command ids to status probes', () => {
   const command = withRunnerCommandId({
     command: 'status',