fix: apply app icon to iOS UI test runner

Author: thymikee

.fallowrc.json

@@ -16,6 +16,7 @@
     "src/bin.ts",
     "src/companion-tunnel.ts",
     "src/daemon.ts",
+    "scripts/patch-xcuitest-runner-icon.ts",
     "src/utils/update-check-entry.ts",
     "test/scripts/metro-prepare-packaged-smoke.mjs",
     "test/integration/*.test.ts",

ios-runner/AgentDeviceRunner/AgentDeviceRunner.xcodeproj/project.pbxproj

@@ -402,8 +402,6 @@
 		20EA2EEE2F2CFC7C001CF0EF /* Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-					ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
-					ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
 					"CODE_SIGN_ENTITLEMENTS[sdk=macosx*]" = AgentDeviceRunnerUITests/AgentDeviceRunnerUITests.entitlements;
 					CODE_SIGN_STYLE = Automatic;
 					CURRENT_PROJECT_VERSION = 1;
@@ -430,8 +428,6 @@
 		20EA2EEF2F2CFC7C001CF0EF /* Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
-					ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
-					ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
 					"CODE_SIGN_ENTITLEMENTS[sdk=macosx*]" = AgentDeviceRunnerUITests/AgentDeviceRunnerUITests.entitlements;
 					CODE_SIGN_STYLE = Automatic;
 					CURRENT_PROJECT_VERSION = 1;

ios-runner/AgentDeviceRunner/AgentDeviceRunner/Assets.xcassets/AppIcon.appiconset/logo.jpg

@@ -104,4 +104,5 @@ xcodebuild build-for-testing \
   ENABLE_CODE_COVERAGE=NO \
   $SIGNING_BUILD_SETTINGS
 
+node --experimental-strip-types scripts/patch-xcuitest-runner-icon.ts "$DERIVED_PATH"
 node scripts/write-xcuitest-cache-metadata.mjs "$PLATFORM" "$DERIVED_PATH" "$DESTINATION"

ios-runner/AgentDeviceRunner/AgentDeviceRunner/Assets.xcassets/Logo.imageset/logo.jpg

@@ -0,0 +1,10 @@
+import { applyXctestRunnerAppIconFromDerivedPath } from '../src/platforms/ios/runner-icon.ts';
+
+const [derivedPath] = process.argv.slice(2);
+
+if (!derivedPath) {
+  console.error('Usage: patch-xcuitest-runner-icon.ts <derived>');
+  process.exit(1);
+}
+
+await applyXctestRunnerAppIconFromDerivedPath(derivedPath);

ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -85,6 +85,9 @@ function isRunnerSourceFile(fileName, filePath) {
     return filePath.includes(`${path.sep}.xcodeproj${path.sep}`);
   }
   return [
+    '.jpg',
+    '.json',
+    '.png',
     '.swift',
     '.plist',
     '.entitlements',