Skip to content

fix: propagate remote config through remote flows#422

Merged
thymikee merged 8 commits into
mainfrom
codex/remote-config-flow
Apr 17, 2026
Merged

fix: propagate remote config through remote flows#422
thymikee merged 8 commits into
mainfrom
codex/remote-config-flow

Conversation

@thymikee

@thymikee thymikee commented Apr 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Propagates --remote-config through normal commands and reuses/persists remote lease/runtime state, with a warning when explicit remote flags bypass saved runtime hints.
  • Honors explicit remote-config profile/session scope without falling back to an unrelated active session; disconnect still permits active fallback for cleanup.
  • Reports Android permission/system foreground blockers for React Native smoke is/wait checks.
  • Adds explicit regression coverage for install-from-source --remote-config writing and reusing the same lease state.
  • Simplifies remote-tenancy docs/skill guidance around passing the same --remote-config to install/open/snapshot/disconnect instead of adding a one-shot command.

Touched-file count: 13 files. Scope expanded from the remote connection CLI flow into selector smoke diagnostics to cover Android permission prompt reliability.

Validation

  • pnpm format
  • pnpm vitest run src/__tests__/cli-client-commands.test.ts src/__tests__/cli-config.test.ts src/__tests__/remote-connection.test.ts src/utils/__tests__/args.test.ts src/core/__tests__/capabilities.test.ts
  • pnpm check:quick
  • pnpm check:unit

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstackincubator.github.io/agent-device/pr-preview/pr-422/

Built to branch gh-pages at 2026-04-17 10:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 778d1868a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli.ts Outdated
Comment on lines 392 to 395
remoteConfig: options.remoteConfig,
cwd: process.cwd(),
env: process.env,
allowActiveFallback: !options.explicitFlagKeys.has('session'),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor profile session for explicit --remote-config commands

resolveActiveConnectionDefaults now resolves connection defaults even when --remote-config is explicitly provided, but it still enables allowActiveFallback whenever --session was not typed on the CLI. In snapshot/open/... --remote-config <path> flows, this can silently switch from the profile’s session to an unrelated active session (same profile path, different session) if no state file exists for the profile session, so a “self-contained” command can run against the wrong remote run/lease context. Consider disabling active-session fallback when remoteConfig is set (or when the profile supplies session) so the profile scope is deterministic.

Useful? React with 👍 / 👎.

@thymikee thymikee changed the title fix: propagate remote config through commands fix: complete remote React Native flow Apr 17, 2026
@thymikee thymikee changed the title fix: complete remote React Native flow fix: propagate remote config through remote flows Apr 17, 2026
@thymikee thymikee merged commit 63ab9d6 into main Apr 17, 2026
12 checks passed
@thymikee thymikee deleted the codex/remote-config-flow branch April 17, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant