fix: improve Maestro test suite replay#601
Merged
Merged
Conversation
|
thymikee
force-pushed
the
codex/fix-maestro-test-suite
branch
3 times, most recently
from
1876c8e to
2274d76
Compare
thymikee
force-pushed
the
codex/fix-maestro-test-suite
branch
from
2274d76 to
31f61ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testcommand sotest --maestro e2e/maestrodiscovers.yml/.yamlflows instead of filtering as normal.adreplay tests.Root Cause
React Navigation's Android and iOS jobs both fail before any flow starts:
Error (INVALID_ARGS): No replay tests matched for --platform android.Error (INVALID_ARGS): No replay tests matched for --platform ios.That points at suite discovery/filtering, not app startup, Metro, install, selectors, emulator, or simulator state. In
agent-device@0.16.0,test --maestroparses the CLI flag, but the structuredtestcommand input did not includebackend/maestro, so command invocation dropped the Maestro backend before daemon suite discovery. Discovery then only considered normal.adreplay tests and platform filtering produced the no-match error.Validation
pnpm exec vitest run src/__tests__/client.test.ts src/daemon/handlers/__tests__/session-replay-vars.test.ts src/daemon/handlers/__tests__/session-test-artifacts.test.ts src/daemon/handlers/__tests__/session.test.ts src/__tests__/cli-network.test.tspnpm check:quickpnpm buildKnown local gap:
pnpm check:unitis blocked in this sandbox by local listener permissions (listen EPERM), the child HTTP server used by the Maestrohttp.postfixture, and Swift script typecheck subprocess failures.CI Notes
Daemon startup failures can still happen before suite code emits JUnit or attempt artifacts. CI jobs should keep uploading
~/.agent-device/**/*.logalongside--artifacts-diroutputs so daemon/runner startup diagnostics are preserved.