Skip to content

feat: Improve React Navigation Maestro reliability#628

Merged
thymikee merged 1 commit into
mainfrom
codex/rn-e2e-perf-reliability
May 30, 2026
Merged

feat: Improve React Navigation Maestro reliability#628
thymikee merged 1 commit into
mainfrom
codex/rn-e2e-perf-reliability

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented May 30, 2026

Summary

Improve Maestro compatibility for the React Navigation native e2e suite.

Details:

  • speed up and harden Android snapshots with richer helper metadata, visible-user filtering, foreground application-window selection, persistent helper reuse, and a bounded 500/100ms idle wait that favors transition stability over mid-animation snapshots
  • add replay timing artifacts so local and CI runs can be compared step-by-step
  • make horizontal swipes more reliable through native gesture swipe presets and reuse those presets from Maestro directional swipes
  • improve Maestro target matching around visible text, breadcrumbs, duplicate visible contexts, regex-vs-plain-text handling, and wide text containers
  • add cross-platform app state cleanup through settings clear-app-state and wire open --clear-app-state to Android pm clear plus iOS simulator container cleanup
  • document the new cleanup command and CI timing artifacts

Validation

  • pnpm format
  • pnpm check:quick
  • pnpm exec fallow audit --changed-since origin/main
  • pnpm exec vitest run src/core/__tests__/dispatch-open.test.ts src/__tests__/cli-grammar.test.ts src/utils/__tests__/args.test.ts src/platforms/android/__tests__/index.test.ts src/platforms/ios/__tests__/index.test.ts src/compat/maestro/__tests__/support-matrix.test.ts src/compat/maestro/__tests__/replay-flow.test.ts
  • pnpm exec vitest run src/platforms/ios/__tests__/index.test.ts src/platforms/android/__tests__/index.test.ts src/core/__tests__/dispatch-open.test.ts src/compat/maestro/__tests__/runtime-targets.test.ts src/utils/__tests__/selector-is-predicates.test.ts src/core/__tests__/dispatch-interactions.test.ts
  • pnpm exec vitest run src/compat/maestro/__tests__/runtime-targets.test.ts src/platforms/android/__tests__/index.test.ts src/platforms/ios/__tests__/index.test.ts src/compat/maestro/__tests__/runtime-interactions.test.ts src/compat/maestro/__tests__/support-matrix.test.ts src/compat/maestro/__tests__/replay-flow.test.ts src/platforms/android/__tests__/snapshot.test.ts src/platforms/android/__tests__/snapshot-helper-session.test.ts src/utils/__tests__/selector-is-predicates.test.ts src/daemon/handlers/__tests__/session.test.ts src/daemon/handlers/__tests__/session-replay.test.ts src/daemon/handlers/__tests__/session-test-artifacts.test.ts src/daemon/handlers/__tests__/session-replay-vars.test.ts src/core/__tests__/dispatch-open.test.ts src/core/__tests__/dispatch-interactions.test.ts src/__tests__/runtime-interactions.test.ts src/__tests__/cli-grammar.test.ts src/replay/__tests__/script.test.ts src/utils/__tests__/args.test.ts src/daemon/__tests__/request-handler-catalog.test.ts
  • pnpm test
  • pnpm build

@thymikee thymikee marked this pull request as ready for review May 30, 2026 19:29
@thymikee thymikee changed the title [codex] Improve React Navigation Maestro reliability feat: Improve React Navigation Maestro reliability May 30, 2026
@thymikee thymikee force-pushed the codex/rn-e2e-perf-reliability branch from dc87290 to d32334e Compare May 30, 2026 19:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-30 20:52 UTC

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc87290c2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/client-types.ts
| (ClientCommandBaseOptions & {
setting: 'clean-user-data';
state: 'clear';
app?: string;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Thread app through the structured settings input

This adds an explicit app option for settings clean-user-data, but the structured settings command still only declares/reads setting/state/latitude/longitude/permission/mode in src/commands/client-command-contracts.ts, so MCP/command-surface callers that pass { app: 'com.foo' } have it omitted by readFieldInput and the daemon receives no target unless there is an active session. In the documented scenario of clearing a specific app id from structured clients, the command fails with “requires an app id or an active app session”; add app to the settings fields/schema and pass it through.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2026

Size Report

Metric Base Current Diff
JS raw 1.1 MB 1.1 MB +10.9 kB
JS gzip 352.7 kB 355.9 kB +3.1 kB
npm tarball 449.6 kB 452.7 kB +3.1 kB
npm unpacked 1.5 MB 1.5 MB +11.4 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.0 ms 27.1 ms +0.1 ms
CLI --help 42.1 ms 42.4 ms +0.3 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/command-metadata.js +9.2 kB +3.6 kB
dist/src/9533.js +3.8 kB +1.1 kB
dist/src/session.js +3.4 kB +1.0 kB
dist/src/221.js +1.6 kB +447 B
dist/src/android.js +760 B +185 B

@thymikee thymikee force-pushed the codex/rn-e2e-perf-reliability branch 3 times, most recently from e47546c to 31bb4ee Compare May 30, 2026 20:14
@thymikee thymikee force-pushed the codex/rn-e2e-perf-reliability branch from 31bb4ee to d5f59ae Compare May 30, 2026 20:18
@thymikee thymikee merged commit ece193e into main May 30, 2026
19 checks passed
@thymikee thymikee deleted the codex/rn-e2e-perf-reliability branch May 30, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant