feat: Improve React Navigation Maestro reliability#628
Conversation
dc87290 to
d32334e
Compare
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc87290c2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | (ClientCommandBaseOptions & { | ||
| setting: 'clean-user-data'; | ||
| state: 'clear'; | ||
| app?: string; |
There was a problem hiding this comment.
Thread app through the structured settings input
This adds an explicit app option for settings clean-user-data, but the structured settings command still only declares/reads setting/state/latitude/longitude/permission/mode in src/commands/client-command-contracts.ts, so MCP/command-surface callers that pass { app: 'com.foo' } have it omitted by readFieldInput and the daemon receives no target unless there is an active session. In the documented scenario of clearing a specific app id from structured clients, the command fails with “requires an app id or an active app session”; add app to the settings fields/schema and pass it through.
Useful? React with 👍 / 👎.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
e47546c to
31bb4ee
Compare
31bb4ee to
d5f59ae
Compare
Summary
Improve Maestro compatibility for the React Navigation native e2e suite.
Details:
gesture swipepresets and reuse those presets from Maestro directional swipessettings clear-app-stateand wireopen --clear-app-stateto Androidpm clearplus iOS simulator container cleanupValidation
pnpm formatpnpm check:quickpnpm exec fallow audit --changed-since origin/mainpnpm exec vitest run src/core/__tests__/dispatch-open.test.ts src/__tests__/cli-grammar.test.ts src/utils/__tests__/args.test.ts src/platforms/android/__tests__/index.test.ts src/platforms/ios/__tests__/index.test.ts src/compat/maestro/__tests__/support-matrix.test.ts src/compat/maestro/__tests__/replay-flow.test.tspnpm exec vitest run src/platforms/ios/__tests__/index.test.ts src/platforms/android/__tests__/index.test.ts src/core/__tests__/dispatch-open.test.ts src/compat/maestro/__tests__/runtime-targets.test.ts src/utils/__tests__/selector-is-predicates.test.ts src/core/__tests__/dispatch-interactions.test.tspnpm exec vitest run src/compat/maestro/__tests__/runtime-targets.test.ts src/platforms/android/__tests__/index.test.ts src/platforms/ios/__tests__/index.test.ts src/compat/maestro/__tests__/runtime-interactions.test.ts src/compat/maestro/__tests__/support-matrix.test.ts src/compat/maestro/__tests__/replay-flow.test.ts src/platforms/android/__tests__/snapshot.test.ts src/platforms/android/__tests__/snapshot-helper-session.test.ts src/utils/__tests__/selector-is-predicates.test.ts src/daemon/handlers/__tests__/session.test.ts src/daemon/handlers/__tests__/session-replay.test.ts src/daemon/handlers/__tests__/session-test-artifacts.test.ts src/daemon/handlers/__tests__/session-replay-vars.test.ts src/core/__tests__/dispatch-open.test.ts src/core/__tests__/dispatch-interactions.test.ts src/__tests__/runtime-interactions.test.ts src/__tests__/cli-grammar.test.ts src/replay/__tests__/script.test.ts src/utils/__tests__/args.test.ts src/daemon/__tests__/request-handler-catalog.test.tspnpm testpnpm build