fix(ios): classify tapSeries/dragSeries/keyboardReturn as interaction commands#643
Merged
thymikee merged 2 commits intoJun 1, 2026
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
… commands tapSeries and dragSeries are the series forms of tap/drag (already interaction commands); keyboardReturn is the sibling of keyboardDismiss (already an interaction command). All three were missing from the historical isInteractionCommand switch — a drift the new CommandTraits table (#642) makes visible. Classifying them as interaction commands gives them the foreground-guard + stabilization preflight that their single-shot/sibling forms already get. Behavior change: these three commands now re-activate a backgrounded target to foreground and pay the stabilization delays before running. Ships separately from the CommandTraits refactor (#642) and should land after that bakes. mouseClick left unchanged: macOS-only and the foreground guard interacts with bespoke macOS activation, so it needs a macOS smoke check first.
thymikee
force-pushed
the
fix/ios-runner-classify-series
branch
from
63ba51f to
ff1f2e9
Compare
|
thymikee
added a commit
that referenced
this pull request
Jun 1, 2026
…cation (#642) * refactor(ios): single CommandTraits table for runner command classification Replace the three hand-maintained switches in RunnerTests+Lifecycle.swift (isInteractionCommand / isReadOnlyCommand / isRunnerLifecycleCommand) with one source of truth: CommandType.traits, an exhaustive switch returning a CommandTraits struct (interaction / readOnly / lifecycle axes), collocated with CommandType in RunnerTests+Models.swift. Pure refactor: every command's classification is reproduced verbatim, and the three predicates become one-line lookups with unchanged signatures, so call sites are untouched. The exhaustive switch makes it a compile error to add a CommandType without classifying it, closing the drift that historically let tapSeries/dragSeries/keyboardReturn fall out of isInteractionCommand. readOnly is a 3-state enum (.always/.never/.conditional); .conditional preserves alert's action-dependent read-only behavior, resolved in isReadOnlyCommand. Classification feeds ADR-0002 session invalidation (the read-only retry that nulls currentApp/currentBundleId), so behavior is intentionally unchanged. Adds the "Runner command traits" term to CONTEXT.md. * docs(ios): note CommandTraits.readOnly .conditional is alert-only (review follow-up) * fix(ios): classify tapSeries/dragSeries/keyboardReturn as interaction commands (#643) * fix(ios): classify tapSeries/dragSeries/keyboardReturn as interaction commands tapSeries and dragSeries are the series forms of tap/drag (already interaction commands); keyboardReturn is the sibling of keyboardDismiss (already an interaction command). All three were missing from the historical isInteractionCommand switch — a drift the new CommandTraits table (#642) makes visible. Classifying them as interaction commands gives them the foreground-guard + stabilization preflight that their single-shot/sibling forms already get. Behavior change: these three commands now re-activate a backgrounded target to foreground and pay the stabilization delays before running. Ships separately from the CommandTraits refactor (#642) and should land after that bakes. mouseClick left unchanged: macOS-only and the foreground guard interacts with bespoke macOS activation, so it needs a macOS smoke check first. * test: cover iOS runner series commands in perf harness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reclassify three commands as interaction commands in the
CommandTraitstable introduced by #642, so they get the foreground-guard + stabilization preflight:tapSeries— series form oftap(already an interaction command)dragSeries— series form ofdrag(already an interaction command)keyboardReturn— sibling ofkeyboardDismiss(already an interaction command)Why
All three were missing from the historical
isInteractionCommandswitch — a drift the single-source-of-truth table makes visible. Their single-shot / sibling forms already pay the preflight; the series/sibling forms should behave consistently.Behavior change
These commands now re-activate a backgrounded target to foreground and pay the stabilization delays (
firstInteractionAfterActivateDelay,postSnapshotInteractionDelay) before running. That's the point — but it's why this is split out from the pure refactor.mouseClickdeliberately excludedmouseClickis the remaining interaction-omission candidate but is macOS-only, and the foreground guard interacts with bespoke macOSactivate()handling (see thescreenshotpath). It needs a macOS smoke check before reclassifying — tracked as a separate follow-up, not included here.Verification (blocking before un-drafting)
tapSeriesworks after backgrounding the target app (gains foreground guard)dragSeriesworks after backgrounding the target appkeyboardReturnkeyboard/focus readiness unchangedtap/dragpaths from the added preflightxcodebuild build-for-testinggreen