fix: bound iOS simulator app termination#654
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound iOS simulator app termination so a stalled
xcrun simctl terminatecannot consume the full replay/test timeout.React Navigation CI timed out on the first Maestro replay action,
close org.reactnavigation.playground, before the app opened. The artifact timing showed the attempt spent the whole 120s inside that first close step. This adds a 15s timeout to the simulator terminate command and covers it with a regression test.Validation
pnpm exec vitest run src/platforms/ios/__tests__/index.test.ts -t "closeIosApp"pnpm check:quickpnpm buildpnpm exec vitest run src/platforms/ios/__tests__/index.test.tspnpm ad close com.example.foobar --platform ios --device "iPhone 17 Pro" --verbosecompleted through the source CLI