Skip to content

fix: bound iOS simulator app termination#654

Merged
thymikee merged 1 commit into
mainfrom
codex/ios-close-timeout
Jun 2, 2026
Merged

fix: bound iOS simulator app termination#654
thymikee merged 1 commit into
mainfrom
codex/ios-close-timeout

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented Jun 2, 2026

Summary

Bound iOS simulator app termination so a stalled xcrun simctl terminate cannot consume the full replay/test timeout.

React Navigation CI timed out on the first Maestro replay action, close org.reactnavigation.playground, before the app opened. The artifact timing showed the attempt spent the whole 120s inside that first close step. This adds a 15s timeout to the simulator terminate command and covers it with a regression test.

Validation

  • pnpm exec vitest run src/platforms/ios/__tests__/index.test.ts -t "closeIosApp"
  • pnpm check:quick
  • pnpm build
  • pnpm exec vitest run src/platforms/ios/__tests__/index.test.ts
  • Live sanity: pnpm ad close com.example.foobar --platform ios --device "iPhone 17 Pro" --verbose completed through the source CLI
  • Confirmed Android validation target is available as Pixel 9 Pro XL

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Size Report

Metric Base Current Diff
JS raw 1.1 MB 1.1 MB +15 B
JS gzip 360.7 kB 360.7 kB +6 B
npm tarball 462.0 kB 462.0 kB +6 B
npm unpacked 1.5 MB 1.5 MB +15 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.2 ms 32.2 ms +4.0 ms
CLI --help 43.6 ms 43.6 ms +0.1 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/apps.js +15 B +6 B

@thymikee thymikee merged commit 25d5a2a into main Jun 2, 2026
18 checks passed
@thymikee thymikee deleted the codex/ios-close-timeout branch June 2, 2026 00:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-02 00:24 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant