docs: clarify physical device signing help#672
Conversation
|
c9f2789 to
5420228
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9f2789df7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Discovery: | ||
| agent-device devices --platform ios | ||
| agent-device devices --platform android | ||
| Use --device <name-or-udid> only when multiple devices are present. |
There was a problem hiding this comment.
Point UDID selection at --udid
In this help topic, --device is not a name-or-UDID selector: it is projected as deviceName, and resolveDevice only compares it against normalized d.name; UDIDs are matched by the separate --udid path. For physical-device users who copy a UDID from agent-device devices, this guidance makes the follow-up command fail with No device named ..., so please describe this as --device <name> or --udid <udid>.
Useful? React with 👍 / 👎.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
5420228 to
387e7db
Compare
Summary
Clarifies physical-device help as connected hardware guidance, with minimal iOS signing instructions for team ID, bundle ID, provisioning profile, and optional signing identity.
Updates the website command docs and adds help-text regression coverage. Touched files: 3; scope stayed in CLI help/docs/tests.
Validation
Verified with
pnpm format,pnpm exec vitest run src/utils/__tests__/args.test.ts, andpnpm typecheck.