Skip to content

docs: clarify physical device signing help#672

Merged
thymikee merged 1 commit into
mainfrom
docs/physical-device-signing-help
Jun 2, 2026
Merged

docs: clarify physical device signing help#672
thymikee merged 1 commit into
mainfrom
docs/physical-device-signing-help

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented Jun 2, 2026

Summary

Clarifies physical-device help as connected hardware guidance, with minimal iOS signing instructions for team ID, bundle ID, provisioning profile, and optional signing identity.

Updates the website command docs and adds help-text regression coverage. Touched files: 3; scope stayed in CLI help/docs/tests.

Validation

Verified with pnpm format, pnpm exec vitest run src/utils/__tests__/args.test.ts, and pnpm typecheck.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-02 15:51 UTC

@thymikee thymikee force-pushed the docs/physical-device-signing-help branch from c9f2789 to 5420228 Compare June 2, 2026 15:44
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9f2789df7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/utils/cli-help.ts
Discovery:
agent-device devices --platform ios
agent-device devices --platform android
Use --device <name-or-udid> only when multiple devices are present.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point UDID selection at --udid

In this help topic, --device is not a name-or-UDID selector: it is projected as deviceName, and resolveDevice only compares it against normalized d.name; UDIDs are matched by the separate --udid path. For physical-device users who copy a UDID from agent-device devices, this guidance makes the follow-up command fail with No device named ..., so please describe this as --device <name> or --udid <udid>.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Size Report

Metric Base Current Diff
JS raw 1.1 MB 1.1 MB +1.9 kB
JS gzip 362.5 kB 363.1 kB +636 B
npm tarball 467.4 kB 468.0 kB +606 B
npm unpacked 1.6 MB 1.6 MB +1.9 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.2 ms 26.5 ms -0.6 ms
CLI --help 42.9 ms 42.7 ms -0.2 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/args.js +1.9 kB +636 B

@thymikee thymikee force-pushed the docs/physical-device-signing-help branch from 5420228 to 387e7db Compare June 2, 2026 15:49
@thymikee thymikee merged commit 0313262 into main Jun 2, 2026
18 checks passed
@thymikee thymikee deleted the docs/physical-device-signing-help branch June 2, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant