feat: add iOS runner prepare command#673
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
agent-device prepare ios-runner --platform ios [--timeout <ms>]as an explicit CI/bootstrap command.The command resolves the target iOS device, ensures it is ready, starts/reuses the XCTest runner via a lightweight
uptimecommand, and reports timing/output without launching an app or mutating session state.Document the command in
help workflowfor iOS CI before replay/test so the runner build/start cost is paid before the first snapshot.Timeout behavior is explicit:
prepare ios-runnernow defaults to a cold-build-safe 240s request timeout, while still accepting--timeout.snapshotdefaults to a faster 30s request timeout and now accepts--timeout <ms>as an escape hatch for legitimately slow captures.prepare ios-runner.prepareis intentionally kept out of the MCP tool surface because it is a shell/CI bootstrap command; agents already get runner prewarm through normalopenflows.Validation
pnpm exec vitest run src/utils/__tests__/daemon-client.test.ts src/utils/__tests__/args.test.ts src/daemon/handlers/__tests__/session.test.ts src/commands/__tests__/command-surface-metadata.test.ts src/mcp/__tests__/router.test.tspnpm check(outside sandbox)node bin/agent-device.mjs snapshot --helpnode bin/agent-device.mjs prepare --helpAGENT_DEVICE_STATE_DIR=/private/tmp/agent-device-feedback-state node bin/agent-device.mjs prepare ios-runner --platform ios --device "iPhone 17 Pro" --verbose->Prepared iOS runner: iPhone 17 ProAGENT_DEVICE_STATE_DIR=/private/tmp/agent-device-feedback-state node bin/agent-device.mjs snapshot -i --platform ios --device "iPhone 17 Pro" --timeout 30000 --json-> passed in ~6.5s