fix: restore snapshot request timeout#680
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
codex/snapshot-request-timeout
branch
from
0f94919 to
98a0b84
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
snapshotdaemon requests to the shared 90sREQUEST_TIMEOUT_MSinstead of the shorter snapshot-specific timeout.This gives CI jobs that have not run
prepare ios-runnerthe previous first-use startup budget.Touched files: 2. Scope stayed within daemon client timeout handling.
Validation
Verified with formatting, the focused daemon-client test file, and the repo quick check:
pnpm formatpnpm exec vitest run src/utils/__tests__/daemon-client.test.tspnpm check:quick