Skip to content

chore: remove dead iOS runner paths #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Feb 20, 2026
Merged

chore: remove dead iOS runner paths #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ final class RunnerTests: XCTestCase {

private static let springboardBundleId = "com.apple.springboard"
private var listener: NWListener?
private var port: UInt16 = 0
private var doneExpectation: XCTestExpectation?
private let app = XCUIApplication()
private lazy var springboard = XCUIApplication(bundleIdentifier: Self.springboardBundleId)
Expand Down Expand Up @@ -351,7 +350,6 @@ final class RunnerTests: XCTestCase {
case .ready:
NSLog("AGENT_DEVICE_RUNNER_LISTENER_READY")
if let listenerPort = self?.listener?.port {
self?.port = listenerPort.rawValue
NSLog("AGENT_DEVICE_RUNNER_PORT=%d", listenerPort.rawValue)
} else {
NSLog("AGENT_DEVICE_RUNNER_PORT_NOT_SET")
Expand Down Expand Up @@ -764,17 +762,6 @@ final class RunnerTests: XCTestCase {
}
let found = findElement(app: activeApp, text: text) != nil
return Response(ok: true, data: DataPayload(found: found))
case .listTappables:
let elements = activeApp.descendants(matching: .any).allElementsBoundByIndex
let labels = elements.compactMap { element -> String? in
guard element.isHittable else { return nil }
let label = element.label.trimmingCharacters(in: .whitespacesAndNewlines)
if label.isEmpty { return nil }
let identifier = element.identifier.trimmingCharacters(in: .whitespacesAndNewlines)
return identifier.isEmpty ? label : "\(label) [\(identifier)]"
}
let unique = Array(Set(labels)).sorted()
return Response(ok: true, data: DataPayload(items: unique))
case .snapshot:
let options = SnapshotOptions(
interactiveOnly: command.interactiveOnly ?? false,
Expand Down Expand Up @@ -908,7 +895,7 @@ final class RunnerTests: XCTestCase {

private func isReadOnlyCommand(_ command: Command) -> Bool {
switch command.command {
case .findText, .listTappables, .snapshot:
case .findText, .snapshot:
return true
case .alert:
let action = (command.action ?? "get").lowercased()
Expand Down Expand Up @@ -1714,7 +1701,6 @@ enum CommandType: String, Codable {
case type
case swipe
case findText
case listTappables
case snapshot
case back
case home
Expand Down
3 changes: 1 addition & 2 deletions src/platforms/ios/runner-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export type RunnerCommand = {
| 'type'
| 'swipe'
| 'findText'
| 'listTappables'
| 'snapshot'
| 'back'
| 'home'
Expand Down Expand Up @@ -664,7 +663,7 @@ export function isRetryableRunnerError(err: unknown): boolean {
}

function isReadOnlyRunnerCommand(command: RunnerCommand['command']): boolean {
return command === 'snapshot' || command === 'findText' || command === 'listTappables' || command === 'alert';
return command === 'snapshot' || command === 'findText' || command === 'alert';
}

function assertRunnerRequestActive(requestId: string | undefined): void {
Expand Down
Loading