perf: reduce Apple runner build overhead#898
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce cold Apple runner build overhead by replacing the SwiftUI host app with a minimal native Objective-C host app and disabling unneeded Xcode build products for runner builds.
Details:
Touched files: 9. Scope stayed within Apple runner build/project code and its existing unit coverage.
Validation
Verified with timeout-wrapped commands to avoid stuck build/check processes:
./node_modules/.bin/vitest run src/platforms/ios/__tests__/runner-client.test.ts: 57 tests passed../node_modules/.bin/oxlint . --deny-warnings: passed../node_modules/.bin/tsc -p tsconfig.json: passed.AGENT_DEVICE_XCUITEST_PLATFORM=macos sh ./scripts/build-xcuitest-apple.sh: passed.AGENT_DEVICE_XCUITEST_PLATFORM=ios sh ./scripts/build-xcuitest-apple.sh: passed.AGENT_DEVICE_XCUITEST_PLATFORM=tvos sh ./scripts/build-xcuitest-apple.sh: passed.Notes:
pnpm format,pnpm exec vitest ..., andpnpm check:quickhung before spawning their underlying tools in this environment, so I interrupted those wrapper processes and ran the local binaries directly with timeouts.