refactor: absorb CLI parser into cli/parser/ — Phase 5#958
Merged
Conversation
Move the CLI argument/flag/help parser out of utils/ into a dedicated src/cli/parser/ folder, per plans/perfect-shape.md §5.5 (utils/ hosts a 3k CLI parser among its buried subsystems). Files moved (3): args, cli-flags, cli-help (args->cli-help intra-set import stays relative). - git renames; importers repointed via the resolve-based codemod (64 importers; staying-utils/kernel deps recomputed to ../../) - no public-export/rslib impact - update scripts/integration-progress-model.ts import + fallow-baselines/ health.json keys (args incl. :high impact variant) Behaviorless path codemod. typecheck/lint/format/build/tests green; integration-progress model still runs.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Member
Author
|
Reviewed against plans/perfect-shape.md section 5.5. This is a constrained CLI parser relocation: the old utils/args, utils/cli-flags, and utils/cli-help files are gone, importers now resolve to src/cli/parser, and the renamed files only adjust relative imports. The fallow baseline and integration-progress script were updated for the new path, and checks are green. No remaining blockers; marking ready-for-human. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the CLI argument/flag/help parser out of
utils/into a dedicatedsrc/cli/parser/folder, per plans/perfect-shape.md §5.5 (utils/hosts a ~3k-LOC CLI parser among its buried subsystems).Files moved (3):
args,cli-flags,cli-help(theargs → cli-helpintra-set import stays relative).How
utils/kerneldeps recomputed to../../).scripts/integration-progress-model.ts, the CLI-flag classification guard) andfallow-baselines/health.jsonkeys (argsincl. its:high impactvariant).Safety
typecheck ✅ · oxlint ✅ · format ✅ · build ✅ · fallow audit ✅ (no issues in 67 changed files) · targeted unit tests ✅ (141 passing) · the integration-progress model still runs. Behaviorless path codemod, 66 files. Independent of #955/#956 (they touch daemon/core, not cli files).