chore: prune public package exports#961
Merged
Merged
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Reviewed the package export pruning against the export map, Rslib entrypoints, facade modules, public/installed-package tests, and client API docs. The remaining public subpaths are backed by build entries, the new contracts/metro/remote-config facades match the documented supported surface, and the removed helpers are no longer advertised as public Node APIs. Checks are green. No blockers; marking ready-for-human. |
thymikee
added
the
ready-for-human
thymikee
force-pushed
the
codex/prune-public-exports
branch
from
2447eb7 to
6674d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prunes unused public package export surface for cloud consumers and moves supported subpaths behind smaller facade entries.
Removes the android-snapshot-helper package export, narrows root and helper subpath type exports, updates Rslib entrypoints, public API tests, and docs. Also drops the extra cloud-confirmed facade exports:
buildIosRuntimeHints,buildAndroidRuntimeHints, and public contract parser schemas. A second-order pass removed now-dead Metro wrapper helpers, stale Android helper barrel exports, and internal export modifiers left over from the narrowed facades.After rebasing onto
origin/main(189b06251),pnpm buildemits1389.0 kBtotal.npm pack --dry-run --jsonreports572,013 Bpacked,1,965,029 Bunpacked, and152entries.Validation
Ran
pnpm format,node_modules/.bin/tsc -p tsconfig.json, the focused public API vitest suite,pnpm check:quick,pnpm build,node_modules/.bin/fallow audit --base origin/main --format compact, andnpm pack --dry-run --json. Double-checked/Users/thymikee/Developer/agent-device-cloudproduction imports against the pruned symbols; remaining production imports are still covered by the retained facades. Also scanned README/docs/website/help source for removed public names and patched the Typed Client docs to avoid staleBatchRequestand Metro helper signatures. Broadfallow dead-codestill reports one unrelated residual:src/core/command-descriptor/types.tsdefineCommandDescriptor.