refactor: split daemon client driver into daemon/client/ — Phase 5#962
Merged
Conversation
Move the daemon CLIENT driver (the in-process side that sends requests to a
running daemon) out of the src/ root into src/daemon/client/, per
plans/perfect-shape.md §5.5 ('daemon/client/ <- daemon-client*.ts'; the
daemon- prefix co-located client driver + server bootstrap at src root).
Files moved (7): daemon-client{,-lifecycle,-metadata,-progress,-rpc,-timeout,
-transport}.
- git renames; 19 importers repointed via the resolve-based codemod
(intra-set stays ./, kernel -> ../../, daemon/remote deps recomputed)
- Layering Guard verified: none import src/commands/* (safe under src/daemon/)
- not a public export; no rslib impact
- update fallow-baselines/health.json keys
Behaviorless path codemod; typecheck/lint/format/build/tests green.
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the daemon client driver (the in-process side that sends requests to a running daemon) out of the
src/root intosrc/daemon/client/, per plans/perfect-shape.md §5.5 ("thedaemon-prefix co-locates client driver + server bootstrap + proxy" at src root).Files moved (7):
daemon-client,daemon-client-lifecycle,daemon-client-metadata,daemon-client-progress,daemon-client-rpc,daemon-client-timeout,daemon-client-transport.How
./,kernel→../../, daemon/remote deps recomputed).src/commands/*, so they're safe now that they live undersrc/daemon/.fallow-baselines/health.json: rekeyed the 4 moved-file entries, and bumpeddaemon-client-lifecycle.tsfrom*_moderate→*_high— the move broughtstartLocalDaemoninto audit scope and surfaced that its pre-existing complexity (unchanged by this move; 17 cyclomatic / 33 cognitive) had a stale baseline entry. Scoped to just this file (no full-baseline regen, which would have swept in unrelated drift).Safety
typecheck ✅ · oxlint ✅ · format ✅ · build ✅ · fallow audit ✅ (no issues in 21 changed files) · daemon-client unit tests ✅ (44 passing). Behaviorless path codemod, 20 files.
Scope note
backend.tsand the daemon server bootstrap remain at root; thedaemon/server/split is a separate follow-up.