fix: extend iOS physical install timeout#964
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Reviewed against #963 and the relevant iOS install/daemon-client timeout path. This targets the exact physical-device |
thymikee
added
the
ready-for-human
thymikee
force-pushed
the
codex/ios-install-timeout
branch
from
773c543 to
7263166
Compare
thymikee
force-pushed
the
codex/ios-install-timeout
branch
from
7263166 to
b760436
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend iOS physical-device install timeouts so larger
.appbundles are not killed by the generic 20s devicectl limit.Closes #963
Validation
Focused unit coverage verifies physical iOS install uses the extended devicectl timeout and install-like daemon requests get a longer client envelope. Ran
pnpm format,pnpm check:quick,pnpm check:unit,pnpm build, andpnpm clean:daemon. Verified live onthymikee-iphoneby installingAgentDeviceTester.app; the install returned success forcom.callstack.agentdevicelab, andapps --all --jsonshowedAgent Device Tester (com.callstack.agentdevicelab)in the device inventory.Touched 6 files; scope stayed within iOS install timeout handling and regression tests.