fix: respect prepare timeout for runner health checks#967
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Reviewed #967 against the prepare ios-runner command path and ADR-0002 helper-session timeout guidance. The CLI/command projection already carries --timeout into the daemon request, the daemon-client uses it as the outer prepare request timeout, and this patch now also derives the Apple runner health-check budget from that explicit prepare timeout while keeping the default 90s behavior and a bounded 180s health cap. Checks are green, including Typecheck, Unit Tests, Integration Tests, Smoke Tests, Swift Runner Unit Compile, and iOS Runner Swift Compatibility. I do not see an actionable blocker; this is ready for maintainer review. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
prepare ios-runner --timeoutextend the runner health-readiness window instead of keeping it hard-capped at 90s.Details
The failing iOS smoke job passed
--timeout 420000, but only build/startup used that budget. On slow hosted macOS/Xcode runners, the rebuilt XCTest runner could still be starting when the fixed 90s health probe expired. The health timeout now derives from the explicit prepare timeout, capped at 3 minutes; default behavior remains 90s.Validation
Focused prepare-handler test passed:
pnpm exec vitest run src/daemon/handlers/__tests__/session.test.ts --testNamePattern "prepare ios-runner".Static and formatting gates passed:
pnpm typecheck,pnpm format.