fix: crash when initialising compiler and forks (#646)

Author: zamotany

packages/haul-core-legacy/package.json

@@ -25,10 +25,10 @@
   },
   "dependencies": {
     "cpx": "^1.5.0",
+    "get-port": "^5.0.0",
     "mime-types": "^2.1.24",
     "mkdirp": "^0.5.1",
-    "ws": "^6.2.1",
-    "xpipe": "^1.0.5"
+    "ws": "^6.2.1"
   },
   "devDependencies": {
     "snapshot-diff": "^0.5.2"

packages/haul-core-legacy/src/compiler/Compiler.js

@@ -34,9 +34,9 @@ module.exports = class Compiler extends EventEmitter {
     this.tasks = new TaskQueue();
     this.logger = logger;
 
-    this.on(Events.REQUEST_BUNDLE, ({ platform, filename, callback }) => {
+    this.on(Events.REQUEST_BUNDLE, async ({ platform, filename, callback }) => {
       if (!this.forks[platform]) {
-        this.forks[platform] = this.initFork({ platform, options });
+        this.forks[platform] = await this.initFork({ platform, options });
       }
 
       if (!this.forks[platform]) return;
@@ -95,10 +95,11 @@ module.exports = class Compiler extends EventEmitter {
   /**
    * Create fork process and attach necessary event listeners.
    */
-  initFork({ platform, options }: { platform: Platform, options: * }) {
+  async initFork({ platform, options }: { platform: Platform, options: * }) {
     let fork;
     try {
       fork = new Fork({ platform, options });
+      await fork.init();
     } catch (message) {
       this.emit(Events.BUILD_FAILED, { platform, message });
       return null;

packages/haul-core-legacy/src/compiler/Fork.js

@@ -7,7 +7,6 @@
 
 import type { Platform } from '../types';
 
-const fs = require('fs');
 const EventEmitter = require('events');
 const Events = require('./events');
 const createForkProcess = require('./createForkProcess');
@@ -32,12 +31,20 @@ module.exports = class Fork extends EventEmitter {
   socket: WebSocket;
   enqueuedMessages: any[];
   isProcessing: boolean;
+  options: any;
 
   constructor({ platform, options }: ForkConstructorArgs) {
     super();
+    this.isProcessing = true;
+    this.enqueuedMessages = [];
+    this.platform = platform;
+    this.options = options;
+  }
 
+  async init() {
     if (!transportServer) {
-      transportServer = createWebSocketServer();
+      // eslint-disable-next-line require-atomic-updates
+      transportServer = await createWebSocketServer();
 
       // WebSocket connection is established after the Fork is created.
       transportServer.on('connection', (socket, req) => {
@@ -58,17 +65,15 @@ module.exports = class Fork extends EventEmitter {
       });
     }
 
-    this.isProcessing = true;
-    this.enqueuedMessages = [];
-    this.platform = platform;
+    const { port } = transportServer.address();
     this.process = createForkProcess(
-      platform,
+      this.platform,
       __dirname,
-      transportServer.options.server.address(),
-      options
+      `localhost:${port}`,
+      this.options
     );
 
-    forks[platform] = this;
+    forks[this.platform] = this;
   }
 
   setSocket(socket: WebSocket) {
@@ -116,10 +121,6 @@ module.exports = class Fork extends EventEmitter {
     }
 
     if (transportServer && !Object.keys(forks).length) {
-      const socketAddress = transportServer.options.server.address();
-      if (fs.existsSync(socketAddress)) {
-        fs.unlinkSync(socketAddress);
-      }
       transportServer.close();
     }
   }

packages/haul-core-legacy/src/compiler/createWebSocketServer.js

@@ -5,47 +5,23 @@
  * @flow
  */
 
-const xpipe = require('xpipe');
+const getPort = require('get-port');
 const http = require('http');
 const { Server } = require('ws');
-const fs = require('fs');
-
-function getSocketAddress() {
-  let address = null;
-  let triesLeft = 20;
-  while (!address && triesLeft > 0) {
-    triesLeft--;
-    address = xpipe.eq(
-      `/tmp/HAUL_SOCKET_${Math.floor(
-        (Date.now() * Math.random()) / 10000000
-      )}_.socket`
-    );
-    if (fs.existsSync(address)) {
-      address = null;
-    }
-  }
-
-  if (!address) {
-    throw new Error('Could not find any free socket address');
-  }
-
-  return address;
-}
 
 /**
  * Create WebSocket server using HTTP server over Unix socket.
  */
-module.exports = function createWebSocketServer() {
-  const socketAddress = getSocketAddress();
-
+module.exports = async function createWebSocketServer() {
   const httpServer = http.createServer();
   const webSocketServer = new Server({
     server: httpServer,
     perMessageDeflate: false,
     maxPayload: 200 * 1024 * 1024,
   });
 
-  httpServer.listen(socketAddress);
+  const port = await getPort();
+  httpServer.listen(port);
 
   return webSocketServer;
 };

packages/haul-core-legacy/src/compiler/worker/initWorker.js

@@ -21,7 +21,7 @@ module.exports = function initWorker({
   [key: string]: string,
 }) {
   const webSocket = new WebSocket(
-    `ws+unix://${socketAddress}:/?platform=${platform}`
+    `ws://${socketAddress}/?platform=${platform}`
   );
 
   function send(type, payload = {}) {