feat: use webpack to resolve initializeCoreLocation file (#669)

Author: zamotany

docs/Configuration.md

@@ -40,11 +40,11 @@ Usually, the return value of `makeConfig` should be returned as default export w
 
 Decorate the entry file(s) with React Native polyfills. You can specify custom `root` directory and path to `InitializeCore.js` file.
 
-| Name      | Type                                                 | Description                                                                                                                                                                                                                                              |
-| --------- | ---------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `entry`   | `string` / `string[]`                                | Entry file(s) path(s)                                                                                                                                                                                                                                    |
-| `options` | `{ root?: string; initializeCoreLocation?: string }` | Specify custom path to `InitializeCore.js` file. `root` and `initializeCoreLocation` are joined together using `path.join`. Defaults: `root` - `process.cwd()`, `initializeCoreLocation` - `node_modules/react-native/Libraries/Core/InitializeCore.js`. |
-| _returns_ | `string[]`                                           | Entry file(s) with polyfill paths                                                                                                                                                                                                                        |
+| Name      | Type                                  | Description                                                                                                                            |
+| --------- | ------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------- |
+| `entry`   | `string` / `string[]`                 | Entry file(s) path(s)                                                                                                                  |
+| `options` | `{ initializeCoreLocation?: string }` | Specify custom path to `InitializeCore.js` file. Defaults: `initializeCoreLocation` - `react-native/Libraries/Core/InitializeCore.js`. |
+| _returns_ | `string[]`                            | Entry file(s) with polyfill paths                                                                                                      |
 
 ### Project configuration reference
 

docs/Recipes.md

@@ -165,7 +165,7 @@ export default makeConfig({
   bundles: {
     index: {
       entry: withPolyfills('./index.js', {
-        initializeCoreLocation: 'node_modules/react-native-windows/Libraries/Core/InitializeCore.js'
+        initializeCoreLocation: 'react-native-windows/Libraries/Core/InitializeCore.js'
       }),
       providesModuleNodeModules: ['react-native', 'react-native-windows'],
       hasteOptions: { platforms: ['native', 'windows'] },

fixtures/react_native_windows_e2e_app/__tests__/appium.test.js

@@ -58,5 +58,5 @@ test('RNWTestApp renders correctly', async () => {
   expect(await getByTestId('app1')).toBeDefined();
   expect(await (await getByTestId('app1LoadTime')).text()).toMatch(/Load time: ([1-9]|[0-9]{2}) ms/);
 
-  expect(await getByTestId('exchangeRates')).toBeDefined();
+  expect(await getByTestId('films')).toBeDefined();
 });

fixtures/react_native_windows_e2e_app/haul.config.js

@@ -7,7 +7,7 @@ export default makeConfig({
   bundles: {
     index: {
       entry: withPolyfills('./index.windows.js', {
-        initializeCoreLocation: 'node_modules/react-native-windows/Libraries/Core/InitializeCore.js'
+        initializeCoreLocation: 'react-native-windows/Libraries/Core/InitializeCore.js'
       }),
       providesModuleNodeModules: ['react-native', 'react-native-windows'],
       hasteOptions: { platforms: ['native', 'windows'] },

…ive_windows_e2e_app/src/ExchangeRates.js …eact_native_windows_e2e_app/src/Films.jsfixtures/react_native_windows_e2e_app/src/ExchangeRates.js renamed to fixtures/react_native_windows_e2e_app/src/Films.js fixtures/react_native_windows_e2e_app/src/ExchangeRates.js renamed to fixtures/react_native_windows_e2e_app/src/Films.js

@@ -3,29 +3,28 @@ import { Text, FlatList } from 'react-native';
 import { Query } from 'react-apollo';
 import gql from 'graphql-tag';
 
-export default function ExchangeRates() {
+export default function Films() {
   return (
     <Query
       query={gql`
         {
-          rates(currency: "USD") {
-            currency
-            rate
+          allFilms {
+            title
           }
         }
       `}
     >
       {({ loading, error, data }) => {
         if (loading) return <Text>Loading...</Text>;
-        if (error) return <Text>Error :(</Text>;
+        if (error) return <Text>Error</Text>;
 
         return (
           <FlatList
-            testID="exchangeRates"
-            data={data.rates}
-            keyExtractor={(item) => item.currency}
+            testID="films"
+            data={data.allFilms}
+            keyExtractor={(item) => item.title}
             renderItem={({ item }) => (
-              <Text>{item.currency}: {item.rate}</Text>
+              <Text>{item.title}</Text>
             )}
           />
         );

fixtures/react_native_windows_e2e_app/src/app1.js

@@ -1,7 +1,7 @@
 import React, { Component, Suspense } from 'react';
 import { StyleSheet, Text, View } from 'react-native';
 
-const ExchangeRates = React.lazy(() => import('./ExchangeRates'));
+const Films = React.lazy(() => import('./Films'));
 
 export default class App extends Component {
   render() {
@@ -10,7 +10,7 @@ export default class App extends Component {
       <View style={styles.container}>
         <Text style={styles.welcome} testID="app1">App 1</Text>
         <Text style={styles.body} testID="app1LoadTime">Load time: {loadTime} ms</Text>
-        <Suspense fallback={<Text>Loading</Text>}><ExchangeRates /></Suspense>
+        <Suspense fallback={<Text>Loading</Text>}><Films /></Suspense>
       </View>
     );
   }

fixtures/react_native_windows_e2e_app/src/host.js

@@ -55,7 +55,7 @@ BundleRegistry.enableLogging();
 
 const cache = new InMemoryCache();
 const apolloClient = new ApolloClient({
-  link: createHttpLink({ uri: "https://48p1r2roz4.sse.codesandbox.io" }),
+  link: createHttpLink({ uri: "https://swapi.graph.cool/" }),
   cache
 });
 

fixtures/react_native_with_haul_0_59x/haul.config.js

@@ -4,19 +4,6 @@ export default makeConfig({
   bundles: {
     index: {
       entry: withPolyfills('./index.js'),
-      transform({ config }) {
-        return {
-          ...config,
-          resolve: {
-            ...config.resolve,
-            alias: {
-              ...config.resolve.alias,
-              // Force React Native to be resolved in exampleApp_0_59x's node_modules
-              'react-native': require.resolve('react-native'),
-            },
-          },
-        };
-      },
     },
   },
 });

packages/haul-cli/src/commands/bundle.ts

@@ -106,7 +106,11 @@ export default function ramBundleCommand(runtime: Runtime) {
           compiler.run((err, info) => {
             if (err || info.hasErrors()) {
               messages.buildFailed(runtime);
-              reject(err ? err : info.toJson({ errorDetails: true }).errors);
+              reject(
+                err
+                  ? err
+                  : info.toJson({ errorDetails: true }).errors.join('\n')
+              );
             } else {
               resolve(info);
             }

packages/haul-cli/src/commands/ramBundle.ts

@@ -116,7 +116,11 @@ export default function ramBundleCommand(runtime: Runtime) {
           compiler.run((err, info) => {
             if (err || info.hasErrors()) {
               messages.buildFailed(runtime);
-              reject(err ? err : info.toJson({ errorDetails: true }).errors);
+              reject(
+                err
+                  ? err
+                  : info.toJson({ errorDetails: true }).errors.join('\n')
+              );
             } else {
               resolve(info);
             }