chore: simplify solution

Author: thiagobrez

packages/react-native-bottom-tabs/ios/TabItem.swift

@@ -5,35 +5,20 @@ struct TabItem: View {
   var icon: PlatformImage?
   var sfSymbol: String?
   var labeled: Bool?
-  var inactiveTintColor: PlatformColor?
-
-  private var tint: Color? {
-    inactiveTintColor.map(Color.init)
-  }
-
-  #if !os(macOS)
-  private var tintedIcon: PlatformImage? {
-    guard let icon else { return nil }
-    guard let inactiveTintColor else { return icon }
-    return icon.withTintColor(inactiveTintColor, renderingMode: .alwaysOriginal)
-  }
-  #endif
 
   var body: some View {
     if let icon {
 #if os(macOS)
       Image(nsImage: icon)
 #else
-      Image(uiImage: tintedIcon ?? icon)
+      Image(uiImage: icon)
 #endif
     } else if let sfSymbol, !sfSymbol.isEmpty {
       Image(systemName: sfSymbol)
         .noneSymbolVariant()
-        .foregroundColor(tint)
     }
     if labeled != false {
       Text(title ?? "")
-        .foregroundColor(tint)
     }
   }
 }

packages/react-native-bottom-tabs/ios/TabView/LegacyTabView.swift

@@ -56,8 +56,7 @@ struct LegacyTabView: AnyTabView {
               title: tabData.title,
               icon: icon,
               sfSymbol: tabData.sfSymbol,
-              labeled: props.labeled,
-              inactiveTintColor: props.inactiveTintColor
+              labeled: props.labeled
             )
             .accessibilityIdentifier(tabData.testID ?? "")
           }

packages/react-native-bottom-tabs/ios/TabView/NewTabView.swift

@@ -48,8 +48,7 @@ struct NewTabView: AnyTabView {
                 title: tabData.title,
                 icon: icon,
                 sfSymbol: tabData.sfSymbol,
-                labeled: props.labeled,
-                inactiveTintColor: props.inactiveTintColor
+                labeled: props.labeled
               )
             }
             #if !os(tvOS)

packages/react-native-bottom-tabs/ios/TabViewImpl.swift

@@ -83,9 +83,6 @@ struct TabViewImpl: View {
       .tintColor(props.selectedActiveTintColor)
       .getSidebarAdaptable(enabled: props.sidebarAdaptable ?? false)
       .onChange(of: props.selectedPage ?? "") { newValue in
-        #if !os(macOS)
-          tabBar?.tintColor = props.selectedActiveTintColor
-        #endif
         #if !os(macOS)
           if props.disablePageAnimations {
             UIView.setAnimationsEnabled(false)
@@ -124,9 +121,9 @@ struct TabViewImpl: View {
     if props.scrollEdgeAppearance == "transparent" {
       configureTransparentAppearance(tabBar: tabBar, props: props)
       return
-    } else {
-      configureStandardAppearance(tabBar: tabBar, props: props)
     }
+
+    configureStandardAppearance(tabBar: tabBar, props: props)
   }
 #endif
 
@@ -141,15 +138,15 @@ struct TabViewImpl: View {
 
     guard let items = tabBar.items else { return }
 
-    let attributes = TabBarFontSize.createNormalStateAttributes(
+    let fontAttributes = TabBarFontSize.createNormalStateAttributes(
       fontSize: props.fontSize,
       fontFamily: props.fontFamily,
       fontWeight: props.fontWeight,
-      inactiveColor: props.inactiveTintColor
+      inactiveColor: nil
     )
 
     items.forEach { item in
-      item.setTitleTextAttributes(attributes, for: .normal)
+      item.setTitleTextAttributes(fontAttributes, for: .normal)
       item.setTitleTextAttributes(selectedAttributes(props: props), for: .selected)
     }
     configureTabBarItemImages(items: items, props: props)
@@ -208,27 +205,11 @@ struct TabViewImpl: View {
       tabBar.scrollEdgeAppearance = appearance.copy()
     }
     if let items = tabBar.items {
-      configureTabBarItemTitles(items: items, props: props)
       configureTabBarItemImages(items: items, props: props)
       configureTabBarItemImagesAfterLayout(tabBar: tabBar, props: props)
     }
   }
 
-  private func configureTabBarItemTitles(items: [UITabBarItem], props: TabViewProps) {
-    let normalAttributes = TabBarFontSize.createNormalStateAttributes(
-      fontSize: props.fontSize,
-      fontFamily: props.fontFamily,
-      fontWeight: props.fontWeight,
-      inactiveColor: props.inactiveTintColor
-    )
-    let selectedAttributes = selectedAttributes(props: props)
-
-    items.forEach { item in
-      item.setTitleTextAttributes(normalAttributes, for: .normal)
-      item.setTitleTextAttributes(selectedAttributes, for: .selected)
-    }
-  }
-
   private func configureTabBarItemImages(items: [UITabBarItem], props: TabViewProps) {
     for (tabBarIndex, item) in items.enumerated() {
       guard let tabData = props.filteredItems[safe: tabBarIndex],