Commit 462f613
committed
fix(TabView): respect user-supplied tabBarHidden
The native side wired tabBarHidden into the SwiftUI tab bar via #76,
but the JS wrapper hardcoded tabBarHidden={!!renderCustomTabBar}
after the {...props} spread, so any value the caller passed was
overwritten before it reached NativeTabView. The prop was also
absent from the TabView Props interface so it never type-checked
at all.
Add tabBarHidden to Props, destructure it explicitly, and keep the
renderCustomTabBar default only as a fallback when the caller does
not supply a value.
Closes #5211 parent f2e12e7 commit 462f613
2 files changed
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
215 | 223 | | |
216 | 224 | | |
217 | 225 | | |
| |||
247 | 255 | | |
248 | 256 | | |
249 | 257 | | |
| 258 | + | |
250 | 259 | | |
251 | 260 | | |
252 | 261 | | |
| |||
404 | 413 | | |
405 | 414 | | |
406 | 415 | | |
407 | | - | |
| 416 | + | |
408 | 417 | | |
409 | 418 | | |
410 | 419 | | |
| |||
0 commit comments