fix(ios): gate index>=4 appear-select on >5-tab overflow (#526)

* fix(ios): gate index>=4 appear-select on >5-tab overflow

TabAppearModifier force-selected any tab with index >= 4 on appear to sync
selection for tabs under the system More tab. That overflow only exists with
more than 5 visible tabs, so on a 5-tab bar the 5th tab (index 4) hijacked the
selection whenever its scene re-appeared (e.g. when the tab bar is re-shown
after .hideTabBar), causing a phantom tab switch that JS can't correct.

Gate the force-select on filteredItems.count > 5. Fixes #525.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore: add changeset

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Thiago Brezinski <thiagobrez@gmail.com>

Author: 3 people

.changeset/bright-taxes-cheat.md

@@ -0,0 +1,5 @@
+---
+'react-native-bottom-tabs': patch
+---
+
+Fix phantom tab switch on iOS when scene re-appears

packages/react-native-bottom-tabs/ios/TabAppearModifier.swift

@@ -18,7 +18,12 @@ struct TabAppearModifier: ViewModifier {
       #endif
 
       #if os(iOS)
-        if context.index >= 4, context.props.selectedPage != context.tabData.key {
+        // Sync selection for tabs nested under the system "More" tab, which
+        // only exists when there are more than 5 visible tabs. Without the
+        // count guard the 5th tab (index 4) of a non-overflowing bar would
+        // force-select itself whenever its scene re-appears (e.g. when the tab
+        // bar is re-shown after `.hideTabBar`), hijacking the selection.
+        if context.props.filteredItems.count > 5, context.index >= 4, context.props.selectedPage != context.tabData.key {
           context.onSelect(context.tabData.key)
         }
       #endif