fix: adjust default font size per platform#379
Merged
okwasniewski merged 1 commit intomainfrom Jul 19, 2025
Merged
Conversation
f14bd64 to
92776b3
Compare
92776b3 to
e9bd2c0
Compare
🦋 Changeset detectedLatest commit: 964612b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e9bd2c0 to
032ab05
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts default font sizes for tab bar labels on iOS platforms to follow iOS UI guidelines, replacing the previous system-calculated default with platform-specific values (10pt for iPhone, 13pt for iPad, 30pt for tvOS).
- Extracts font handling logic into a dedicated
TabBarFontSizeutility class - Implements device-specific default font sizes based on iOS design guidelines
- Refactors existing font attribute creation to use the new centralized approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TabViewImpl.swift | Removes inline font handling and integrates new TabBarFontSize utility |
| TabBarFontSize.swift | New utility class providing platform-specific font defaults and attribute creation |
| PlatformAliases.swift | Adds PlatformFont typealias for cross-platform font compatibility |
| fancy-papayas-battle.md | Changeset documentation for the font size adjustment |
Comments suppressed due to low confidence (2)
packages/react-native-bottom-tabs/ios/TabBarFontSize.swift:86
- The new isFontFamilyAvailable method lacks test coverage and is not used in the current implementation. Consider adding tests or removing if unused.
static func isFontFamilyAvailable(_ family: String) -> Bool {
packages/react-native-bottom-tabs/ios/PlatformAliases.swift:40
- The new PlatformFont typealias is defined but not used in the current implementation. This suggests incomplete refactoring or dead code.
typealias PlatformFont = NSFont
032ab05 to
964612b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adjusts default font sizes per platform according to this article: https://www.learnui.design/blog/ios-font-size-guidelines.html
Also addresses this issue: #375