Apply typeface and size individually in android text appearance.#393
Merged
okwasniewski merged 2 commits intocallstack:mainfrom Jul 30, 2025
Merged
Apply typeface and size individually in android text appearance.#393okwasniewski merged 2 commits intocallstack:mainfrom
okwasniewski merged 2 commits intocallstack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 7b92802 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves Android text appearance handling for bottom tabs by separating the application of font size and typeface properties. This allows developers to set custom font families without inheriting unwanted font scaling behavior, which is particularly important for tab bars where consistent sizing is preferred.
Key changes:
- Split text appearance application to handle size and typeface independently
- Allow setting custom font family without automatic font scaling
- Maintain backwards compatibility while providing more granular control
okwasniewski
approved these changes
Jul 30, 2025
Collaborator
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Looks good, thanks for working on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a custom font with bottom tabs today on Android, another font size is also set by default. With the biggest difference from the standard one being that it scales with the system font scale, which the default one does not.
PR Description
Improvement: This splits the application of text appearance, so that size and typeface(family and weight) is applied individually. So that when setting one or the other, only that is applied. So one could use a custom font family, without getting the font scaling which is usually not wanted with tab bars.
How to test?
On Android apply
fontFamily+fontWeightandfontSizeindividually intabLabelStyle, and see they can be used individually.Screenshots
Before and after examples with bigger system font scale on Android