Skip to content

Commit 2b48ea4

Browse files
feat: support non default variants
# Conflicts: # gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantProcessor.kt
1 parent ff08de2 commit 2b48ea4

2 files changed

Lines changed: 17 additions & 13 deletions

File tree

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,22 @@ object RNSourceSets {
4444
}
4545

4646
private fun configureSourceSets() {
47-
androidExtension.sourceSets.getByName("main") { sourceSet ->
48-
for (bundlePathSegment in listOf(
49-
// outputs for RN <= 0.81
50-
"createBundleReleaseJsAndAssets",
51-
// outputs for RN >= 0.82
52-
"react/release",
53-
)) {
54-
sourceSet.assets.srcDirs("$appBuildDir/generated/assets/$bundlePathSegment")
55-
sourceSet.res.srcDirs("$appBuildDir/generated/res/$bundlePathSegment")
47+
project.extensions.getByType(LibraryExtension::class.java).libraryVariants.all { variant ->
48+
val upperCaseVariantName = variant.name.replaceFirstChar(Char::titlecase)
49+
50+
androidExtension.sourceSets.getByName("main") { sourceSet ->
51+
for (bundlePathSegment in listOf(
52+
// outputs for RN <= 0.81
53+
"createBundle${upperCaseVariantName}JsAndAssets",
54+
// outputs for RN >= 0.82
55+
"react/release",
56+
)) {
57+
sourceSet.assets.srcDirs("$appBuildDir/generated/assets/$bundlePathSegment")
58+
sourceSet.res.srcDirs("$appBuildDir/generated/res/$bundlePathSegment")
59+
}
60+
61+
sourceSet.java.srcDirs("$moduleBuildDir/generated/autolinking/src/main/java")
5662
}
57-
58-
sourceSet.java.srcDirs("$moduleBuildDir/generated/autolinking/src/main/java")
5963
}
6064

6165
androidExtension.sourceSets.getByName("release") {

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantProcessor.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ class VariantProcessor(private val variant: LibraryVariant) : BaseProject() {
5555
throw TaskNotFound("Can not find $preBuildTaskPath task")
5656
}
5757

58-
if (capitalizedVariantName == "Release") {
59-
prepareTask.dependsOn(":app:createBundleReleaseJsAndAssets")
58+
if (capitalizedVariantName.contains("Release")) {
59+
prepareTask.dependsOn(":app:createBundle${upperCaseVariantName}JsAndAssets")
6060
}
6161

6262
val bundleTask = variantTaskProvider.bundleTaskProvider(project, variant.name)

0 commit comments

Comments
 (0)