refactor: alter the Android API for loading JS bundle from disk to support a separate option

Author: artus9033

docs/docs/docs/api-reference/java.mdx

@@ -69,7 +69,8 @@ A function used to initialize a React Native Brownfield singleton. Keep in mind
 - `useDeveloperSupport`: `Boolean` - Flag to use dev support.
 - `packages`: `List<ReactPackage>` - List of your React Native Native modules.
 - `mainModuleName`: `String` - Path to react native entry file (when loading from Metro).
-- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`; if this path starts with `file://`, the JS bundle will be loaded from a local file, not from app's assets.
+- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`
+- `bundleFilePath`: `String` - Optional, should start with `file://`, in which case the JS bundle will be loaded from a local file; alternatively, can start with `asset://`, in which case it is equivalent to `bundleAssetPath` passed the value without the `asset://` prefix.
 
 **Examples:**
 

docs/docs/docs/api-reference/kotlin.mdx

@@ -52,7 +52,8 @@ A function used to initialize a React Native Brownfield singleton. Keep in mind
 - `useDeveloperSupport`: `Boolean` - Flag to use dev support.
 - `packages`: `List<ReactPackage>` - List of your React Native Native modules.
 - `mainModuleName`: `String` - Path to react native entry file (when loading from Metro).
-- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`; if this path starts with `file://`, the JS bundle will be loaded from a local file, not from app's assets.
+- `bundleAssetPath`: `String` - Path to react native bundle asset file (when loading from app assets), appended to `asset://`
+- `bundleFilePath`: `String` - Optional, should start with `file://`, in which case the JS bundle will be loaded from a local file; alternatively, can start with `asset://`, in which case it is equivalent to `bundleAssetPath` passed the value without the `asset://` prefix.
 
 **Examples:**
 

packages/react-native-brownfield/android/src/main/java/com/callstack/reactnativebrownfield/ReactNativeBrownfield.kt

@@ -72,16 +72,13 @@ class ReactNativeBrownfield private constructor(val reactHost: ReactHost) {
             onJSBundleLoaded: OnJSBundleLoaded? = null
         ) {
             val reactHost: ReactHost by lazy {
-                val bundlePath = options["bundleAssetPath"] as? String ?: "index.android.bundle"
-                val isFilePath = bundlePath.startsWith("/") || bundlePath.startsWith("file://") || bundlePath.startsWith("assets://")
-
                 getDefaultReactHost(
                     context = application,
                     packageList = (options["packages"] as? List<*> ?: emptyList<ReactPackage>())
                         .filterIsInstance<ReactPackage>(),
                     jsMainModulePath = options["mainModuleName"] as? String ?: "index",
-                    jsBundleAssetPath = bundlePath,
-                    jsBundleFilePath = if (isFilePath) bundlePath else null,
+                    jsBundleAssetPath = options["bundleAssetPath"] as? String ?: "index.android.bundle",
+                    jsBundleFilePath = options["bundleFilePath"] as? String,
                     useDevSupport = options["useDeveloperSupport"] as? Boolean
                         ?: ReactBuildConfig.DEBUG,
                     jsRuntimeFactory = null