Skip to content

Commit 6ea8da9

Browse files
authored
chore: gradle plugin housekeeping (#249)
* chore: remove obsolete ArtifactMatcher in gradle plugin * chore: fix missing space in log
1 parent fed9d95 commit 6ea8da9

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ open class ExpoPublishingHelper(val brownfieldAppProject: Project) {
9797
@Suppress("UNCHECKED_CAST")
9898
(json["variants"] as? List<MutableMap<String, Any>>)?.forEach { variant ->
9999
Logging.log(
100-
"Injecting dependency to Gradle module JSON for variant" +
100+
"Injecting dependency to Gradle module JSON for variant " +
101101
"'${variant["name"]}': ${dependencyToAdd.groupId}:" +
102102
"${dependencyToAdd.artifactId}:${dependencyToAdd.version}",
103103
)

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/shared/Constants.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ object Constants {
4949
ArtifactMatcher(groupId = StringMatcher.literal("host.exp.exponent")),
5050
ArtifactMatcher(groupId = StringMatcher.literal("BareExpo")),
5151
ArtifactMatcher(groupId = StringMatcher.regex("expo.*")),
52-
// below: groupId of the local Expo app itself that may be referenced by some of the Expo packages
53-
ArtifactMatcher(groupId = StringMatcher.literal("ExpoApp")),
5452
// below: a broken transitive dependency that has no version specified and thus breaks the build
5553
ArtifactMatcher(
5654
groupId = StringMatcher.literal("org.jetbrains.kotlin"),

0 commit comments

Comments
 (0)