Skip to content

Commit 8684bca

Browse files
committed
feat: use getByName to reduce array operations
1 parent 3aa095d commit 8684bca

1 file changed

Lines changed: 11 additions & 30 deletions

File tree

gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt

Lines changed: 11 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -384,38 +384,19 @@ open class ExpoPublishingHelper(val brownfieldAppProject: Project) {
384384
pkgProject: Project,
385385
dependencies: VersionMediatingDependencySet,
386386
) {
387-
pkgProject.configurations
388-
.filter { cfg ->
389-
setOf(
390-
"test",
391-
"androidTest",
392-
"kapt",
393-
"annotationProcessor",
394-
"lint",
395-
"detached",
396-
).none {
397-
cfg.name.contains(it, ignoreCase = true)
398-
}
399-
}
400-
.filter { cfg ->
401-
setOf("implementation", "api").any {
402-
cfg.name.contains(it, ignoreCase = true)
387+
listOf("implementation", "api").forEach {
388+
pkgProject.configurations.getByName(it).dependencies.forEach { dep ->
389+
if (dep.group != null) {
390+
dependencies.add(
391+
DependencyInfo.fromGradleDep(
392+
groupId = dep.group!!,
393+
artifactId = dep.name,
394+
version = dep.version,
395+
),
396+
)
403397
}
404398
}
405-
.forEach { cfg ->
406-
cfg.dependencies
407-
.filter { dep ->
408-
dep.group != null
409-
}.forEach { dep ->
410-
dependencies.add(
411-
DependencyInfo.fromGradleDep(
412-
groupId = dep.group!!,
413-
artifactId = dep.name,
414-
version = dep.version,
415-
),
416-
)
417-
}
418-
}
399+
}
419400
}
420401

421402
/**

0 commit comments

Comments
 (0)