fix: fail early for non-extension bundle path

Author: hurali97

packages/react-native-brownfield/ios/BrownfieldBundlePathResolver.swift

@@ -1,11 +1,21 @@
 import Foundation
 
 enum BrownfieldBundlePathResolver {
-  static func resourceComponents(from bundlePath: String) -> (resourceName: String, fileExtension: String) {
-    let resourceURLComponents = bundlePath.components(separatedBy: ".")
-    let withoutLast = resourceURLComponents.dropLast()
-    let resourceName = withoutLast.joined(separator: ".")
-    let fileExtension = resourceURLComponents.last ?? ""
+  enum Error: Swift.Error {
+    case invalidBundlePath(String)
+  }
+
+  static func resourceComponents(from bundlePath: String) throws -> (
+    resourceName: String,
+    fileExtension: String
+  ) {
+    let fileExtension = (bundlePath as NSString).pathExtension
+    let resourceName = (bundlePath as NSString).deletingPathExtension
+
+    guard !fileExtension.isEmpty, !resourceName.isEmpty else {
+      throw Error.invalidBundlePath(bundlePath)
+    }
+
     return (resourceName, fileExtension)
   }
 }

packages/react-native-brownfield/ios/ExpoHostRuntime.swift

@@ -125,11 +125,15 @@ class ExpoHostRuntimeDelegate: ExpoReactNativeFactoryDelegate {
     return RCTBundleURLProvider.sharedSettings().jsBundleURL(
       forBundleRoot: entryFile)
 #else
-    let (resourceName, fileExtension) = BrownfieldBundlePathResolver.resourceComponents(
-      from: bundlePath
-    )
-
-    return bundle.url(forResource: resourceName, withExtension: fileExtension)
+    do {
+      let (resourceName, fileExtension) = try BrownfieldBundlePathResolver.resourceComponents(
+        from: bundlePath
+      )
+      return bundle.url(forResource: resourceName, withExtension: fileExtension)
+    } catch {
+      assertionFailure("Invalid bundlePath '\(bundlePath)': \(error)")
+      return nil
+    }
 #endif
   }
 }

packages/react-native-brownfield/ios/ReactNativeHostRuntime.swift

@@ -22,11 +22,15 @@ class ReactNativeBrownfieldDelegate: RCTDefaultReactNativeFactoryDelegate {
 #if DEBUG
     return RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: entryFile)
 #else
-    let (resourceName, fileExtension) = BrownfieldBundlePathResolver.resourceComponents(
-      from: bundlePath
-    )
-
-    return bundle.url(forResource: resourceName, withExtension: fileExtension)
+    do {
+      let (resourceName, fileExtension) = try BrownfieldBundlePathResolver.resourceComponents(
+        from: bundlePath
+      )
+      return bundle.url(forResource: resourceName, withExtension: fileExtension)
+    } catch {
+      assertionFailure("Invalid bundlePath '\(bundlePath)': \(error)")
+      return nil
+    }
 #endif
   }
 }