refactor: cleanup

Author: hurali97

packages/react-native-brownfield/src/expo-config-plugin/android/utils/androidManifest.ts

@@ -1,12 +1,10 @@
 import type { AndroidConfig } from '@expo/config-plugins';
 
-/** Classification: generic Android utility data shape. */
 export type AndroidManifestMetaDataEntry = {
   name: string;
   value: string;
 };
 
-/** Classification: generic Android utility data shape. */
 export type AndroidStringResourceEntry = {
   name: string;
   value: string;
@@ -17,7 +15,6 @@ const META_DATA_TAG_REGEX =
   /<meta-data\b[\s\S]*?(?:\/>|>[\s\S]*?<\/meta-data>)/g;
 const STRING_TAG_REGEX = /<string\b[\s\S]*?>[\s\S]*?<\/string>/g;
 
-/** Classification: generic Android utility parser. */
 export function extractApplicationMetaData(
   manifestContent: string
 ): AndroidManifestMetaDataEntry[] {
@@ -35,7 +32,6 @@ export function extractApplicationMetaData(
     );
 }
 
-/** Classification: generic Android utility parser. */
 export function extractApplicationMetaDataFromAndroidManifest(
   androidManifest: AndroidConfig.Manifest.AndroidManifest
 ): AndroidManifestMetaDataEntry[] {
@@ -58,7 +54,6 @@ export function extractApplicationMetaDataFromAndroidManifest(
     );
 }
 
-/** Classification: generic Android utility parser. */
 export function extractStringResourcesFromXml(
   stringsContent: string,
   resourceNames: string[]
@@ -75,7 +70,6 @@ export function extractStringResourcesFromXml(
     );
 }
 
-/** Classification: generic Android utility parser. */
 export function extractStringResourcesFromResourcesXml(
   stringsXml: AndroidConfig.Resources.ResourceXML,
   resourceNames: string[]
@@ -102,7 +96,6 @@ export function extractStringResourcesFromResourcesXml(
     );
 }
 
-/** Classification: generic Android utility renderer. */
 export function renderLibraryManifestApplication(
   metaDataEntries: AndroidManifestMetaDataEntry[]
 ): string {
@@ -120,7 +113,6 @@ export function renderLibraryManifestApplication(
   return `  <application>\n${renderedMetaDataEntries}\n  </application>`;
 }
 
-/** Classification: generic Android utility renderer. */
 export function renderLibraryStringResources(
   stringResources: AndroidStringResourceEntry[]
 ): string {

packages/react-native-brownfield/src/expo-config-plugin/android/utils/expo-updates.ts

@@ -21,17 +21,12 @@ const STRING_REFERENCE_REGEX = /^@string\/([A-Za-z0-9_.]+)$/;
 const EXPO_UPDATES_META_DATA_PREFIX = 'expo.modules.updates.';
 
 /**
- * Canonical Expo Updates extraction pipeline.
- *
- * This plugin copies values from the app's finalized Android files while running
+ * This copies values from the app's finalized Android files while running
  * inside `withDangerousMod` / `withFinalizedMod`. In that phase, the stable
  * cross-plugin input is the on-disk XML after Expo and other config plugins have
- * finished mutating it, so production extraction intentionally uses raw file
+ * finished mutating it, so extraction intentionally uses raw file
  * contents as the source of truth.
- *
  */
-
-/** Classification: Expo Updates-specific logic used by production code. */
 export function readExpoUpdatesApplicationMetaData(
   androidDir: string,
   appModuleName: string
@@ -54,7 +49,6 @@ export function readExpoUpdatesApplicationMetaData(
   );
 }
 
-/** Classification: Expo Updates-specific logic used by production code. */
 export function extractExpoUpdatesApplicationMetaData(
   manifestContent: string
 ): AndroidManifestMetaDataEntry[] {
@@ -63,7 +57,6 @@ export function extractExpoUpdatesApplicationMetaData(
   );
 }
 
-/** Classification: Expo Updates-specific logic used by production code. */
 export function readExpoUpdatesStringResources(
   androidDir: string,
   appModuleName: string,

packages/react-native-brownfield/src/expo-config-plugin/android/withAndroidModuleFiles.ts

@@ -218,10 +218,6 @@ export function syncAndroidModuleExpoUpdatesFromAppFiles({
   androidDir: string;
   config: ResolvedBrownfieldPluginConfigWithAndroid;
 }): void {
-  // Read the finalized app files from disk instead of relying on parsed mod
-  // results. This keeps Expo Updates sync compatible with the dangerous/finalized
-  // mod phases, where other config plugins may already have rewritten the app
-  // manifest or strings resources that we need to mirror into the library module.
   const appModuleName = config.android.moduleName;
   const expoUpdatesMetaData = readExpoUpdatesApplicationMetaData(
     androidDir,