feat(ios): allow overriding the bundle instance#112
Merged
okwasniewski merged 3 commits intomainfrom Jun 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables specifying a custom Bundle instance for locating the main.jsbundle on iOS instead of always using Bundle.main.
- Introduces a
bundleproperty on the delegate defaulting toBundle.main. - Updates
sourceURL(for:)to use the customizablebundle. - Exposes an
@objc public var bundleonReactNativeBrownfieldto override at runtime.
Comments suppressed due to low confidence (3)
ios/ReactNativeBrownfield.swift:62
- [nitpick] The property name
bundleis very generic and shadows theBundletype; consider renaming it to something likeresourceBundleorbundleOverrideto improve clarity.
@objc public var bundle: Bundle = Bundle.main {
ios/ReactNativeBrownfield.swift:60
- The doc comment should mention when and how to set this property (e.g., before initializing the bridge) and what effect it has on bundle resolution.
* Default value: Bundle.main
ios/ReactNativeBrownfield.swift:25
- Consider adding a unit or integration test to verify that overriding
bundleproperly resolves resources from a non-main bundle.
return bundle.url(forResource: resourceName, withExtension: fileExtension)
3 tasks
Contributor
okwasniewski
left a comment
There was a problem hiding this comment.
Can you also update the docs about it? 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundleURLon iOS was usingBundle.mainto retrieve themain.jsbundlefile. Bundle.main returns the Bundle instance of the target that executes the code. This means the generatedmain.jsbundlefile should always be placed atReactBrownfieldframework's bundle for it to work.This PR makes it possible to change the bundle instance, so the framework target that uses
@_exportedto reexport rn-brownfield can also own themain.jsbundlefile.Test plan
main.jsbundleto that different target