fix(ios): remove brownie and react brownfield exported directives#240
Merged
fix(ios): remove brownie and react brownfield exported directives#240
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the @_exported import directives for Brownie and ReactBrownfield modules from the iOS framework interface template. The generated framework will now only provide the ReactNativeBundle symbol, while users must explicitly import ReactBrownfield and Brownie if they need features from those modules. This change fixes a dependency issue where users were forced to install Brownie even when not using it, and makes dependencies more explicit and opt-in.
Changes:
- Removed
@_exported import ReactBrownfieldand@_exported import Browniefrom the framework interface template - Added
import Foundationfor the Bundle class and changed to regularimport ReactBrownfieldfor the extension
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thymikee
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the need to re-export the
BrownieandReactBrownfieldmodules as they are already linked to the host App after the framework generation. This also fixes the bug where the user does not want to installBrownie, without this PR, they will have to installBrownieeven if they don't use it.Test plan
CI Passes - 🟢