Skip to content

fix: broken support for custom appProjectName in Gradle Plugin #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artus9033 merged 6 commits into from
Mar 19, 2026
Merged

fix: broken support for custom appProjectName in Gradle Plugin #275

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6de79e
fix: invoke RNSourceSets.configure after Gradle evaluation to properl…
artus9033 Mar 17, 2026
4864e95
fix: make VariantProcessor use GP extension's appProjectName for reso…
artus9033 Mar 17, 2026
04fcb01
chore: add changeset
artus9033 Mar 17, 2026
1e9d179
fix: resolve project using Gradle APIs in VariantProcessor to support…
artus9033 Mar 17, 2026
da338a6
chore: bump up Gradle plugin version
artus9033 Mar 17, 2026
9c68769
chore: add changeset
artus9033 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/crisp-animals-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'brownfield': patch
'@callstack/react-native-brownfield': patch
---

fix: support custom app project name in Gradle plugin via extension's appProjectName config field
2 changes: 1 addition & 1 deletion ...ct/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNBrownfieldPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ class RNBrownfieldPlugin
project.evaluationDependsOn(EXPO_PROJECT_LOCATOR)
}

RNSourceSets.configure(project, extension)
projectConfigurations.setup()
registerRClassTransformer()

project.afterEvaluate {
RNSourceSets.configure(project, extension)
afterEvaluate()

if (this.isExpoProject) {
Expand Down
6 changes: 4 additions & 2 deletions .../brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* We can't use the new `com.android.build.gradle.api.LibraryVariant`
* as of now.
*
* We may want to re-visit this in future.
* We may want to re-visit this in the future.
*/

package com.callstack.react.brownfield.processors
Expand All @@ -17,6 +17,7 @@ import com.callstack.react.brownfield.artifacts.ArtifactsResolver.Companion.ARTI
import com.callstack.react.brownfield.exceptions.TaskNotFound
import com.callstack.react.brownfield.shared.BaseProject
import com.callstack.react.brownfield.utils.AndroidArchiveLibrary
import com.callstack.react.brownfield.utils.Extension
import com.callstack.react.brownfield.utils.capitalized
import org.gradle.api.Task
import org.gradle.api.artifacts.ResolvedArtifact
Expand Down Expand Up @@ -57,7 +58,8 @@ class VariantProcessor(private val variant: LibraryVariant) : BaseProject() {
}

if (capitalizedVariantName.contains("Release")) {
prepareTask.dependsOn(":app:createBundle${capitalizedVariantName}JsAndAssets")
val projectExt = project.extensions.getByType(Extension::class.java)
prepareTask.dependsOn(":${projectExt.appProjectName}:createBundle${capitalizedVariantName}JsAndAssets")
Comment thread
artus9033 marked this conversation as resolved.
Outdated
}

val bundleTask = variantTaskProvider.bundleTaskProvider(project, variant.name)
Expand Down
Loading