fix: duplicate symbols for ReactBrownfield#296
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the iOS packaging command to prevent duplicate symbol / duplicate Objective‑C class registration issues when consumer apps embed both BrownfieldLib (which already contains ReactBrownfield symbols) and ReactBrownfield.xcframework.
Changes:
- Add detection of
ReactBrownfield.xcframeworkin the package output directory. - Run
stripFrameworkBinaryonReactBrownfield.xcframeworkto make it interface-only when present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artus9033
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes - callstackincubator/rock#636
Problem
Consumer apps link
BrownfieldLib(which, via CocoaPods /inherit! :complete, already includesReactBrownfieldin the same framework binary) and shipReactBrownfield.xcframeworkfor importReactBrownfieldand Xcode integration. That loads two copies of the same Swift/ObjC types into the process, which surfaces as duplicate Objective‑C class registration and related duplicate-symbol issues.Solution
After
packageIosActioncompletes, ifReactBrownfield.xcframeworkexists under the package output directory, we run the samestripFrameworkBinarystep already used forBrownie.xcframeworkandBrownfieldNavigation.xcframework. Thexcframeworkstays usable for imports and Swift interfaces, while its Mach-O is replaced with a stub so implementations are not duplicated in apps that embed bothBrownfieldLibandReactBrownfield.xcframework.Test plan
Before
Before.mov
After
After.mov