Skip to content

fix: duplicate symbols for ReactBrownfield #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurali97 merged 2 commits into from
Apr 10, 2026
Merged

fix: duplicate symbols for ReactBrownfield #296

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32e352
fix: duplicate symbols for ReactBrownfield
hurali97 Apr 9, 2026
29f27c3
chore: run changeset
hurali97 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/cli/src/brownfield/commands/packageIos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import fs from 'node:fs';
import path from 'node:path';

import {
Expand Down Expand Up @@ -95,6 +96,17 @@ export const packageIosCommand = curryOptions(
platformConfig
);

const reactBrownfieldXcframeworkPath = path.join(
packageDir,
'ReactBrownfield.xcframework'
);
if (fs.existsSync(reactBrownfieldXcframeworkPath)) {
// Strip the binary from ReactBrownfield.xcframework to make it interface-only.
// This avoids duplicate symbols when consumer apps embed both BrownfieldLib
// (which contains ReactBrownfield symbols) and ReactBrownfield.xcframework.
Comment thread
hurali97 marked this conversation as resolved.
stripFrameworkBinary(reactBrownfieldXcframeworkPath);
}

if (hasBrownie) {
const productsPath = path.join(options.buildFolder, 'Build', 'Products');
const brownieOutputPath = path.join(packageDir, 'Brownie.xcframework');
Expand Down
Loading